Optimize multicast delegate thunk #104222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alternative to dotnet#104219 for consideration. RyuJIT generates somewhat better code for the canonical `Invoke` pattern: The other PR: ``` 00007FF7AE041978 mov rcx,qword ptr [rbx+rbp*8+10h] 00007FF7AE04197D mov rax,qword ptr [rcx+8] 00007FF7AE041981 mov rdx,qword ptr [rcx+20h] 00007FF7AE041985 mov rcx,rax 00007FF7AE041988 call rdx ``` This PR: ``` 00007FF69D2B1978 mov rax,qword ptr [rbx+rbp*8+10h] 00007FF69D2B197D mov rcx,qword ptr [rax+8] 00007FF69D2B1981 call qword ptr [rax+20h] ```
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #104219 for consideration.
RyuJIT generates somewhat better code for the canonical
Invokepattern:The other PR:
This PR: