Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: Account for mixed-enregistered locals when zeroing without block-init #104593

Merged
merged 4 commits into from
Jul 10, 2024
Merged

JIT: Account for mixed-enregistered locals when zeroing without block-init #104593

merged 4 commits into from
Jul 10, 2024

Commits on Jul 9, 2024

  1. JIT: Account for mixed-enregistered locals when zeroing without block… 

    …-init

Locals that are in registers at the beginning of a function do not need
to have their stack home zeroed. `genFnProlog` already skips these
locals when computing the range of bytes to zero; however,
`genZeroInitFrame` was not doing the same in the non-block init case,
which does not make use of the range computed by `genFnProlog`. This
could cause an unbounded amount of (unnecessary) codegen during
zero-initing, which is not legal to have in the prolog.

Fix dotnet#104570
    @jakobbotsch
    jakobbotsch committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    95dc247 View commit details
    Browse the repository at this point in the history

  2. Tighten assert

    @jakobbotsch
    jakobbotsch committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    ec73237 View commit details
    Browse the repository at this point in the history

  3. Remove check

    @jakobbotsch
    jakobbotsch committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    c9a724f View commit details
    Browse the repository at this point in the history

  4. Oops

    @jakobbotsch
    jakobbotsch committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    1dade32 View commit details
    Browse the repository at this point in the history