Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TensorPrimitives.{Max/Min}MagnitudeNumber #104651

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Add TensorPrimitives.{Max/Min}MagnitudeNumber #104651

merged 1 commit into from
Jul 10, 2024

Conversation

stephentoub
Copy link
Member

Contributes to #98862

@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@stephentoub stephentoub mentioned this pull request Jul 10, 2024
Open
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

This was referenced Jul 10, 2024
Closed
Closed
@stephentoub stephentoub merged commit d40ac7c into dotnet:main Jul 10, 2024
79 of 83 checks passed
@stephentoub stephentoub deleted the maxminmagnumber branch July 10, 2024 16:56
matouskozak added a commit to matouskozak/runtime that referenced this pull request Jul 11, 2024
@matouskozak
Revert "Add TensorPrimitives.{Max/Min}MagnitudeNumber (dotnet#104651)"
b1ddf97 
This reverts commit d40ac7c.
@alexrp alexrp mentioned this pull request Jul 16, 2024
Open
This was referenced Jul 17, 2024
Open
Open
This was referenced Jul 19, 2024
Open
Open
Open
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tannergooding tannergooding tannergooding approved these changes

Assignees

@stephentoub stephentoub

Labels
area-System.Numerics new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephentoub @tannergooding