SPMI: Fix a few memory leaks #104691
Merged
SPMI: Fix a few memory leaks #104691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
This was referenced Jul 11, 2024
Open
|
cc @dotnet/jit-contrib |
AndyAyersMS
reviewed
Jul 14, 2024
| @@ -446,8 +443,8 @@ int __cdecl main(int argc, char* argv[]) | |||
| } | |||
| } | |||
|
|
|||
| // Create a new CompileResult for this compilation (the CompileResult from the stored file is | |||
| // in originalCR if necessary). | |||
| delete mc->cr; | |||
There was a problem hiding this comment.
Suggested change
| delete mc->cr; | |
| mc->Reset(); |
(also news up a CR, so below isn't needed)
There was a problem hiding this comment.
Makes sense, made that change. I also moved the call to the end of the loop and only when there is going to be a next iteration of the repeatCount loop.
AndyAyersMS
approved these changes
Jul 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.