Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't make web requests in HttpClient trimming test #104718

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Don't make web requests in HttpClient trimming test #104718

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b5b58d0
Don't make web requests in HttpClient trimming test
MichalStrehovsky Jul 11, 2024
c5943c7
Update System.Net.Http.TrimmingTests.proj
MichalStrehovsky Jul 12, 2024
fb4358a
Delete src/libraries/System.Net.Http/tests/TrimmingTests/HttpClientTe…
MichalStrehovsky Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/libraries/System.Net.Http/tests/TrimmingTests/HttpClientTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,13 @@ class Program

static async Task<int> Main(string[] args)
{
using var client = new HttpClient();
using var response = await client.GetAsync("https://www.microsoft.com");
var result = await response.Content.ReadAsStringAsync();
Console.WriteLine(result);
if (Environment.GetEnvironmentVariable("Never") == "Ever")
{
using var client = new HttpClient();
using var response = await client.GetAsync("https://www.microsoft.com");
var result = await response.Content.ReadAsStringAsync();
Console.WriteLine(result);
}

const string quicDll = "System.Net.Quic.dll";
var quicDllExists = File.Exists(Path.Combine(AppContext.BaseDirectory, quicDll));
Expand Down