Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0-staging] Add libicu74 as a known ICU version #104756

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 11, 2024

Backport of #104754 to release/6.0-staging

/cc @jkoritzinsky

Customer Impact

  • Customer reported
  • Found internally

Cannot install Microsoft-built .NET 6.0 runtimes or SDKs on Ubuntu 24.04

Regression

  • Yes
  • No

Testing

Verified the package name in Ubuntu 24.04's repository matches the existing pattern and made sure that updating the pattern generated the right package name

Risk

Low, this only adds an additional known ICU package name. It does not change any existing known package names.

Ubuntu 24.04 ships ICU v74 as the libicu74 package, so we need to add it as a known version.

Contributes to dotnet/sdk#40506

This does not affect source-build. Canonical defines their own deb packages and they do not use the runtime-deps package.
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we can take this as tell mode.

cc @carlossanlop

@jkoritzinsky jkoritzinsky added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jul 11, 2024
@jkoritzinsky jkoritzinsky added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Jul 11, 2024
@jkoritzinsky
Copy link
Member

Marking as no-merge until questions in dotnet/sdk#40506 are resolved.

@carlossanlop
Copy link
Member

Reminder: Monday July 15th is Code Complete day, that's the deadline to get this included in the August Release.

@jkoritzinsky
Copy link
Member

I spoke offline with Rich. We'll merge this in now and make an issue for next steps to better guide users to the best experience.

@jkoritzinsky
Copy link
Member

/ba-g timeout failure unrelated

@jkoritzinsky jkoritzinsky removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Jul 17, 2024
@jkoritzinsky jkoritzinsky merged commit 9cc13ba into release/6.0-staging Jul 17, 2024
86 of 95 checks passed
@jkoritzinsky jkoritzinsky deleted the backport/pr-104754-to-release/6.0-staging branch July 17, 2024 20:37
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Setup Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants