Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment nested depth in TooDeepJsonDocument test by 10x #105836

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

stephentoub
Copy link
Member

Hopefully fix #105532
cc: @lambdageek

@lambdageek
Copy link
Member

/azp run runtime-coreclr outerloop

@lambdageek
Copy link
Member

/cc @ivdiazsa

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@ivdiazsa ivdiazsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eiriktsarpalis
Copy link
Member

Seems to be causing the test to time out in the interpreter:

   System.Text.Json.Tests: [Long Running Test] 'System.Text.Json.Serialization.Tests.JsonElementTests.DeepEquals_TooDeepJsonDocument_ThrowsInsufficientExecutionStackException', Elapsed: 00:06:59
   System.Text.Json.Tests: [Long Running Test] 'System.Text.Json.Serialization.Tests.JsonElementTests.DeepEquals_TooDeepJsonDocument_ThrowsInsufficientExecutionStackException', Elapsed: 00:08:59

...
[EXECUTION TIMED OUT]

I think we can just disable the test in that environment.

@stephentoub
Copy link
Member Author

Seems to be causing the test to time out in the interpreter

@kg

@kg
Copy link
Contributor

kg commented Aug 2, 2024

Yes, I recommend just disabling this for interp. My guess is that the cost of things like method calls is so much higher that it makes the cost of this test inflated vs JIT.

@stephentoub stephentoub merged commit 63c6279 into main Aug 8, 2024
80 of 84 checks passed
@stephentoub stephentoub deleted the stephentoub-patch-1 branch August 8, 2024 11:09
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants