JIT: Fix genHWIntrinsic_R_R_RM_I assertion handling when ins is INS_insertps
#106100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
This was referenced Aug 8, 2024
TIHan
changed the title
Sse41.Insert, do not contain vec-zero on op1/op2 if the immediate value is greater than 63genHWIntrinsic_R_R_RM_I assertion handling when ins is INS_insertps
|
@jit-contrib @tannergooding this is ready |
tannergooding
approved these changes
Aug 8, 2024
tannergooding
approved these changes
Aug 8, 2024
|
Current failures are unrelated; Pri0 tests passed. Also, the second previous run ran all green. Merging. |
This was referenced Aug 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #105467