Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WebAssembly nuget package references to RC1 SDK #107673

Merged
merged 6 commits into from
Sep 13, 2024

Conversation

MichalStrehovsky
Copy link
Member

No description provided.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 11, 2024
@MichalStrehovsky MichalStrehovsky added area-Infrastructure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Sep 11, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@MichalStrehovsky
Copy link
Member Author

The only things failing are the wasm legs. @maraf, @ilonatommy, @lewing, @pavelsavara do the failures ring a bell?

@lewing
Copy link
Member

lewing commented Sep 11, 2024

you should update all the versions in Versions.props that come from dotnet/runtime not just ilcompiler. the particular failure is because the ApiCompatTasksVersion is older than the runtime in the sdk

@lewing
Copy link
Member

lewing commented Sep 11, 2024

dotnet/arcade#15071 will update global.json once it flows and you can use darc to properly update eng/Version.Details.xml with the runtime versions from the sdk

@MichalStrehovsky
Copy link
Member Author

you should update all the versions in Versions.props that come from dotnet/runtime not just ilcompiler. the particular failure is because the ApiCompatTasksVersion is older than the runtime in the sdk

We cannot do a proper update from dotnet/runtime. Last time it was attempted in #106873 and every single commit updating from dotnet/runtime was reverted. What's the targeted set of updates we need to fix wasm?

The ILCompiler package update will go away once #107583 merges. I just put it here temporarily for testing.

@lewing
Copy link
Member

lewing commented Sep 12, 2024

you should update all the versions in Versions.props that come from dotnet/runtime not just ilcompiler. the particular failure is because the ApiCompatTasksVersion is older than the runtime in the sdk

We cannot do a proper update from dotnet/runtime. Last time it was attempted in #106873 and every single commit updating from dotnet/runtime was reverted. What's the targeted set of updates we need to fix wasm?

The ILCompiler package update will go away once #107583 merges. I just put it here temporarily for testing.

Sorry, was away from my computer before and thought this was 9.0. SdkVersionForWorkloadTesting has to be >= the sdk version in global.json. That is usually handled by flow from sdk back to runtime but can be problematic on framework transitions.

@agocke
Copy link
Member

agocke commented Sep 12, 2024

I’m fine waiting for dotnet/arcade#15071 if it’s almost ready

@lewing
Copy link
Member

lewing commented Sep 12, 2024

#107746 has the flow for 10

@akoeplinger
Copy link
Member

#107746 bumped the SDK to RC1 but it didn't contain the wasm nuget package updates so that is the only change left here.

@akoeplinger akoeplinger changed the title Update to RC1 SDK Update WebAssembly nuget package references to RC1 SDK Sep 13, 2024
@akoeplinger akoeplinger merged commit 82cb4f1 into dotnet:main Sep 13, 2024
35 checks passed
@MichalStrehovsky MichalStrehovsky deleted the rc1update branch September 13, 2024 20:58
jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Sep 17, 2024
* Update to RC1 SDK

* Update Versions.props

* Update Versions.props

* Update Versions.props

---------

Co-authored-by: Larry Ewing <lewing@microsoft.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants