-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/9.0] Fix constraint on FrozenSet.{Try}GetAlternateLookup #107847
Conversation
Normally we would have caught this oversight immediately, as tests would have failed to compile, but unlike the vast majority of our test suites, System.Collections.Immutable's test suite references the implementation assembly rather than the ref assembly, in order to access internals via InternalsVisibleTo. Grrr.
Note regarding the
|
1 similar comment
Note regarding the
|
Tagging subscribers to this area: @dotnet/area-system-collections |
Might need to check if this change has any ramifications on API docs authoring. |
/ba-g all failures are known |
This is also in main. Once we update the ref assemblies for dotnet-api-docs with the RC2 ones, the docs structure will get updated and it will match. |
In other words, no action is needed to address the docs concern. |
Same for packaging, right? |
No package authoring changes needed for OOBs yet. We begin those when we start servicing this branch. |
Backport of #107846 to release/9.0
Fixes #107840 (comment)
/cc @stephentoub
Customer Impact
Regression
Testing
n/a
Risk
Low. It's just adding the additional anti-constraint in the ref assembly.
@carlossanlop, does this require any special authoring? It has a nuget package, but we also haven't shipped 9.0 GA yet.