Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0] Fix constraint on FrozenSet.{Try}GetAlternateLookup #107847

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 16, 2024

Backport of #107846 to release/9.0
Fixes #107840 (comment)

/cc @stephentoub

Customer Impact

  • Customer reported
  • Found internally

Regression

  • Yes
  • No

Testing

n/a

Risk

Low. It's just adding the additional anti-constraint in the ref assembly.

@carlossanlop, does this require any special authoring? It has a nuget package, but we also haven't shipped 9.0 GA yet.

Normally we would have caught this oversight immediately, as tests would have failed to compile, but unlike the vast majority of our test suites, System.Collections.Immutable's test suite references the implementation assembly rather than the ref assembly, in order to access internals via InternalsVisibleTo. Grrr.
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-collections
See info in area-owners.md if you want to be subscribed.

@eiriktsarpalis
Copy link
Member

Might need to check if this change has any ramifications on API docs authoring.

@stephentoub
Copy link
Member

/ba-g all failures are known

@carlossanlop
Copy link
Member

This is also in main. Once we update the ref assemblies for dotnet-api-docs with the RC2 ones, the docs structure will get updated and it will match.

@carlossanlop
Copy link
Member

In other words, no action is needed to address the docs concern.

@stephentoub
Copy link
Member

In other words, no action is needed to address the docs concern.

Same for packaging, right?

@carlossanlop
Copy link
Member

Same for packaging, right?

No package authoring changes needed for OOBs yet. We begin those when we start servicing this branch.

@carlossanlop carlossanlop merged commit e5eae50 into release/9.0 Sep 16, 2024
83 of 91 checks passed
@carlossanlop carlossanlop deleted the backport/pr-107846-to-release/9.0 branch September 16, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Collections Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants