[release/9.0] Empty slice fix #107880
Merged
[release/9.0] Empty slice fix #107880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/area-system-numerics-tensors |
|
@michaelgsharp, @ericstj - is this a behavioral breaking change from RC1? |
|
@artl93 in RC1 it would throw an error erroneously. So it is a behavioral change but its going from throwing an error (incorrectly) to not throwing an error (correctly) which should be fine. |
artl93
approved these changes
Sep 16, 2024
|
/ba-g The single test failure is a known test failure not related to these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #107316 to release/9.0
/cc @michaelgsharp
Customer Impact
Fixes #106536. When slicing an empty Tensor, you should be able to ask for .. and get back an empty tensor. This PR enables this behavior.
Regression
Testing
Added in automated testing around slicing empty Tensors. We did not have a test for that before but now we do.
Risk
Low risk. Tensor is going to be a preview release and was added in this 9.0 release.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.