[release/9.0] dont try to capture threadId for NativeAOT #108088
+16
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/gc |
jeffschwMSFT
approved these changes
Sep 20, 2024
jeffschwMSFT
added
the
Servicing-consider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #108045 to release/9.0
/cc @mangod9
Customer Impact
Regression
The new instrumentation change can potentially AV if the threadId isn't at 0x130 offset. Have put the specific code under config and excluded for NativeAOT
Testing
There hasn't been a reliable repro for the failures. Only seen in CI in the SDK repo currently. Based on the change sets this was found to be the likely culprit, and this change reduces the impact of the earlier instrumentation change
Risk
Low, adds a config so the new codepath is only exercised when the new config is specified.