Cleanly split BinDir to RuntimeBinDir and TestBinDir #42829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trylek
requested review from
echesakov,
ViktorHofer,
safern,
naricc and
SamMonoRT
trylek
requested review from
akoeplinger,
EgorBo,
marek-safar,
steveisok and
vargaz
as code owners
trylek
changed the title
This was referenced Sep 29, 2020
naricc
approved these changes
Oct 1, 2020
safern
reviewed
Oct 1, 2020
safern
approved these changes
Oct 1, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the annoying ambiguity that BinDir sometimes refers to
artifacts/bin/coreclr/$(OSPlatformConfig) and sometimes to
artifacts/tests/coreclr/$(OSPlatformConfig) for easier orientation.
I'm not sure about the packaging projects under src/coreclr/.nuget,
does anyone happen to know whether they require special treatment?
Thanks
Tomas
/cc @dotnet/runtime-infrastructure