[release/5.0] Don't rev the platforms package unless we ship it #46688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Tagging subscribers to this area: @safern, @ViktorHofer |
ViktorHofer
approved these changes
Jan 7, 2021
safern
approved these changes
Jan 7, 2021
|
Mono test failure is #43981 |
|
I think we should wait to merge this until @Anipik comes back. Branch is locked right now for 5.0.2 release. |
Anipik
approved these changes
Jan 12, 2021
Branch will be opened tomorrow for the new changes. |
|
@ericstj can we close this one as this change is included in eventlog pr as well |
|
Sure we can close this if we merged the other PRs which cherry-picked it. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should technically pin more here, similar to #46447, but just doing the minimal in servicing to unblock #46598 and #46590
This is infra only change so should be mergeable on review.