SPMI: adjust near differ offset compare logic #48245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a clause that maps result1 and result2 offsets to a common base and then compares that result. This fixes some noisy diffs from instrumented Tier0 compiles, where the probe addresses can vary from run to run.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
@BruceForstall PTAL Would be nice to run this on some "known" diff cases to make sure it's not suppressing true diffs. Any ideas? |
You could induce diffs by, e.g., turning off a phase for one JIT. But you'll have to figure out how to induce just the right kind of diff for this to hit or not hit. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a clause that maps result1 and result2 offsets to a common base and
then compares that result.
This fixes some noisy diffs from instrumented Tier0 compiles, where the
probe addresses can vary from run to run.