[wasm][testing] hosting webSocket echo server in xharness process #52546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsCompanion change to dotnet/xharness#593, not interesting yet.
|
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsCompanion change to dotnet/xharness#593, not interesting yet.
|
pavelsavara
force-pushed
the
pr_wasm_loopback_outerloop
branch
from
c710081
to
8a0eadd
Compare
7 tasks
lambdageek
reviewed
May 14, 2021
| <Project Sdk="Microsoft.NET.Sdk.Web"> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>net5.0</TargetFramework> |
There was a problem hiding this comment.
Should be $(NetCoreAppToolCurrent)
lambdageek
reviewed
May 14, 2021
| @@ -51,4 +41,10 @@ | |||
| <ItemGroup> | |||
| <PackageReference Include="System.Net.TestData" Version="$(SystemNetTestDataVersion)" /> | |||
| </ItemGroup> | |||
| <ItemGroup Condition="'$(TargetOS)' == 'Browser'"> | |||
| <!-- TODO | |||
| <ProjectReference Include="$(CommonTestPath)System/Net/Prerequisites/MonoNetTestServer/MonoNetTestServer.csproj" /> | |||
There was a problem hiding this comment.
- I think you want
<ProjectReference ... ReferenceOutputAssembly="false"/>because you just want to establish a build-order, not to actually link it in to the tests - You actually should reference a .proj that uses the
MSBuildtask (or maybe an Exec. not sure) to build the server for the build machine RID, not for browser-wasm.
|
Closed in favor of #52923 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<Scenario>WasmTestOnBrowser</Scenario>to System.Net.WebSockets.Client.Tests.csprojCompanion change to dotnet/xharness#593, not interesting yet.