Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Task.Delay() <exception> XML comments #53392

Merged
merged 3 commits into from
May 28, 2021
Merged

Fix Task.Delay() <exception> XML comments #53392

merged 3 commits into from
May 28, 2021

Conversation

thomsj
Copy link
Contributor

@thomsj thomsj commented May 27, 2021

Fix ObjectDisposedException comments to state that the exception is
thrown when the CancellationTokenSource of the CancellationToken is
disposed, and not the CancellationToken itself.

@thomsj
Fix Task.Delay() <exception> XML comments
824a17f 
Fix `ObjectDisposedException` comments to state that the exception is
thrown when the `CancellationTokenSource` of the `CancellationToken` is
disposed, and not the `CancellationToken` itself.
@ghost
Copy link

ghost commented May 27, 2021

Tagging subscribers to this area: @carlossanlop
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix ObjectDisposedException comments to state that the exception is
thrown when the CancellationTokenSource of the CancellationToken is
disposed, and not the CancellationToken itself.

Author: thomsj
Assignees: -
Labels:

area-System.Threading.Tasks
Milestone: -

sharwell
sharwell approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@sharwell sharwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the motivation behind the change, but would consider alternative messaging.

src/libraries/System.Private.CoreLib/src/System/Threading/Tasks/Task.cs Outdated Show resolved Hide resolved
thomsj and others added 2 commits May 28, 2021 20:28
@thomsj @sharwell
Use suggested message
ba1255a 
Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com>
@thomsj
Use suggested message
e316b3f
stephentoub
stephentoub approved these changes May 28, 2021
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@stephentoub stephentoub merged commit 7cb1017 into dotnet:main May 28, 2021
@runfoapp runfoapp bot mentioned this pull request May 28, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Jun 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sharwell sharwell sharwell approved these changes

@stephentoub stephentoub stephentoub approved these changes

Assignees
No one assigned
Labels
area-System.Threading.Tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomsj @sharwell @stephentoub