Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm][workload] Move emscripten to its own manifest for versioning reasons #54349

Closed
wants to merge 21 commits into from

Conversation

lewing
Copy link
Member

@lewing lewing commented Jun 17, 2021

Emsdk side dotnet/emsdk#29

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@@ -1,5 +1,8 @@
{
"version": "${WorkloadVersion}",
"depends-on": {
"Microsoft.NET.Workload.Emscripten": "${EmscriptenVersion}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, but we would need to stand up the same setup tasks we're planning for dotnet/runtime in dotnet/emsdk to produce installers and generate VS authoring

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it isn't required we don't need to do it but It sounds like we'll have the versioning problems otherwise?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I think you're right. Let say EMSDK produces 6.0.0-preview7.123 and that flows to runtime. Runtime produces preview7.456 and we build MSIs for these and wrap them in nuget packages and push them.

But now runtime rebuilds for something else and produces 457. EMSDK hasn't changed, but we rebuild the closure to make sure everything is in sync for VS and CLI based installs. We'd end up trying to push the 123 package again which is already on the feed.

Copy link
Member Author

@lewing lewing Jun 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing that isn't clear to me here is should this name include the .Manifest-6.0.100 band or not? I assume so but I'm not sure what that implies about or later style band versioning

cc @dsplaisted

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the workload IDs in the workload manifest do not include band numbers. The NuGet packages that are created will.

@lewing lewing changed the title [wasm][workload] Move emscripten to it's own manifest for versioning reasons [wasm][workload] Move emscripten to its own manifest for versioning reasons Jun 17, 2021
@lewing lewing force-pushed the emsdk-manifest branch 2 times, most recently from b4056e2 to dfb8adf Compare June 24, 2021 15:43
@lewing lewing marked this pull request as ready for review July 2, 2021 17:35
@lewing lewing requested a review from marek-safar as a code owner July 2, 2021 17:35
@lewing lewing requested review from steveisok and radical July 3, 2021 01:29
@lewing lewing closed this Jul 8, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants