Use XmlWriter.Create instead of XmlTextWriter #54949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
reviewed
Jun 30, 2021
src/libraries/System.Private.Xml/src/System/Xml/Serialization/XmlSerializer.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jun 30, 2021
src/libraries/System.Private.Xml/src/System/Xml/Serialization/XmlSerializer.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jun 30, 2021
src/libraries/System.Private.Xml/src/System/Xml/Serialization/XmlSerializer.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Jun 30, 2021
HongGit
approved these changes
Jul 6, 2021
…XmlSerializer.cs Co-authored-by: Stephen Toub <stoub@microsoft.com>
…XmlSerializer.cs Co-authored-by: Stephen Toub <stoub@microsoft.com>
…XmlSerializer.cs Co-authored-by: Stephen Toub <stoub@microsoft.com>
HongGit
approved these changes
Jul 12, 2021
mconnew
reviewed
Jul 13, 2021
| XmlTextWriter xmlWriter = new XmlTextWriter(textWriter); | ||
| xmlWriter.Formatting = Formatting.Indented; | ||
| xmlWriter.Indentation = 2; | ||
| XmlWriter xmlWriter = XmlWriter.Create(textWriter, new XmlWriterSettings() { CheckCharacters = true, IndentChars = " ", Indent = true }); | ||
| Serialize(xmlWriter, o, namespaces); |
There was a problem hiding this comment.
Why explicitly set CheckCharacters and IndentChars? You are seeting them to their default values. Indent is the only property which you are changing from the default.
mconnew
reviewed
Jul 13, 2021
| XmlTextWriter xmlWriter = new XmlTextWriter(stream, null); | ||
| xmlWriter.Formatting = Formatting.Indented; | ||
| xmlWriter.Indentation = 2; | ||
| XmlWriter xmlWriter = XmlWriter.Create(stream, new XmlWriterSettings() { CheckCharacters = true, IndentChars = " ", Indent = true }); | ||
| Serialize(xmlWriter, o, namespaces); |
There was a problem hiding this comment.
Same for this, skip setting values to the defaults.
mconnew
requested changes
Jul 13, 2021
HongGit
approved these changes
Jul 13, 2021
mconnew
approved these changes
Jul 15, 2021
This was referenced Jul 20, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use XmlReader/Writer.Create instead of XmlTextReader/Writer.
XmlTextWriter is not strict about some of the things it writes. Like
the null character, which is technically illegal in XML 1.0 and 1.1.
(The way we used the XmlTextReader counterpart, we would end
up successfully serializing a null character, and then hit an exception
when trying to deserialize what we just serialized. This inability to
round trip breaks a core tenet of serialization.)
Since the long ago days of .Net 2.0, Microsoft has been
recommending people to use XmlReader/Writer.Create()
instead of directly instantiating XmlTextReader/Writer. This PR
will bring us in line with those recommendations from long ago.
Fixes #1411