Use RandomAccess/File.OpenHandle in a few more places #55150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsPlaces where we don't need to pay for the FileStream and the access pattern is easily replaced.
|
|
This fails because of MS_IO_REDIST, and it's too annoying to use ifdefs everywhere for it. We should really consider stopping building this package. cc: @adamsitnik |
|
Updated with undos for the File changes that would have required large ifdefs. |
We plan to reevaluate this package for .NET 7 and hopefully remove it #54919 (comment) cc @jeffhandley |
adamsitnik
reviewed
Jul 5, 2021
adamsitnik
reviewed
Jul 8, 2021
adamsitnik
approved these changes
Jul 8, 2021
src/libraries/System.Private.CoreLib/src/System/IO/FileSystem.Unix.cs
Outdated
Show resolved
Hide resolved
Places where we don't need to pay for the FileStream and the access pattern is easily replaced.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Places where we don't need to pay for the FileStream and the access pattern is easily replaced.