Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0-preview7] Fix an error printed out when install_location file is missing #56330

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 26, 2021

Backport of #56327 to release/6.0-preview7

/cc @agocke @vitek-karas

Customer Impact

The changes for multi-arch caused what should be a COREHOST_TRACE diagnostic to be output as an error to stderr instead of being silent as normal.
The other app behavior does not change, but many people scrape the output of their app, and the extra text will break them.
This only occurs when using the apphost, which mostly isn’t used in CI.

Testing

Unit tests

Risk

Low. Changes only a call to the error helper.

The app will still run, but we must not print out anything in that case.
@ghost
Copy link

ghost commented Jul 26, 2021

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #56327 to release/6.0-preview7

/cc @agocke @vitek-karas

Customer Impact

Testing

Risk

Author: github-actions[bot]
Assignees: -
Labels:

area-Host

Milestone: -

@agocke
Copy link
Member

agocke commented Jul 26, 2021

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@agocke agocke force-pushed the backport/pr-56327-to-release/6.0-preview7 branch from 7c21753 to 67ebe2b Compare July 26, 2021 23:18
@agocke
Copy link
Member

agocke commented Jul 26, 2021

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@agocke
Copy link
Member

agocke commented Jul 27, 2021

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@agocke agocke closed this Jul 27, 2021
@agocke agocke reopened this Jul 27, 2021
Copy link
Member

@agocke agocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmitche mmitche merged commit 45efb2f into release/6.0-preview7 Jul 27, 2021
@akoeplinger akoeplinger deleted the backport/pr-56327-to-release/6.0-preview7 branch July 27, 2021 15:20
@ghost ghost locked as resolved and limited conversation to collaborators Aug 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants