Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WASM] Node Debugger #56473

Closed
wants to merge 116 commits into from
Closed

[WASM] Node Debugger #56473

wants to merge 116 commits into from

Commits on Jun 15, 2021

  1. Did some cleanup

    @Daniel-Genkin
    Daniel-Genkin committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    b78c830 View commit details
    Browse the repository at this point in the history

  2. faked loading async while supporting actual async loading

    @Daniel-Genkin
    Daniel-Genkin committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    644d165 View commit details
    Browse the repository at this point in the history

  3. more cleanup and fixes

    @Daniel-Genkin
    Daniel-Genkin committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    93255ad View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2021

  1. removed export

    @Daniel-Genkin
    Daniel-Genkin committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    7f9105f View commit details
    Browse the repository at this point in the history

  2. more cleanup

    @Daniel-Genkin
    Daniel-Genkin committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    9489f23 View commit details
    Browse the repository at this point in the history

  3. more cleanup

    @Daniel-Genkin
    Daniel-Genkin committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    57fd10c View commit details
    Browse the repository at this point in the history

  4. removed unused variables

    @Daniel-Genkin
    Daniel-Genkin committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    e6e5615 View commit details
    Browse the repository at this point in the history

  5. var -> let or const

    @Daniel-Genkin
    Daniel-Genkin committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    1d60b57 View commit details
    Browse the repository at this point in the history

  6. slight readability fix

    @Daniel-Genkin
    Daniel-Genkin committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    3253d86 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2021

  1. Addressed PR comments

    @Daniel-Genkin
    Daniel-Genkin committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    eef11f4 View commit details
    Browse the repository at this point in the history

  2. Fixed typo

    @Daniel-Genkin
    Daniel-Genkin committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    ac87c42 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2021

  1. prep io for nodejs + comments

    @Daniel-Genkin
    Daniel-Genkin committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    7fd1a1a View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2021

  1. Fixed merge conflicts

    @Daniel-Genkin
    Daniel-Genkin committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    9624ece View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into wasm-normalize-io

    @Daniel-Genkin
    Daniel-Genkin committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    4814973 View commit details
    Browse the repository at this point in the history

  3. Fixed failing tests

    @Daniel-Genkin
    Daniel-Genkin committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    19a5f69 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2021

  1. Addressed PR comments about formatting issues

    @Daniel-Genkin
    Daniel-Genkin committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    11be10d View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2021

  1. added type defintions

    @Daniel-Genkin
    Daniel-Genkin committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    d0388ed View commit details
    Browse the repository at this point in the history

  2. Merge branch 'wasm-normalize-io' of https://github.com/Daniel-Genkin/… 

    …runtime into wasm-node-flag
    @Daniel-Genkin
    Daniel-Genkin committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    fa25185 View commit details
    Browse the repository at this point in the history

  3. copied over changes from other PR

    @Daniel-Genkin
    Daniel-Genkin committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    7e6424f View commit details
    Browse the repository at this point in the history

  4. various fixes to make it work

    @Daniel-Genkin
    Daniel-Genkin committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    e4122d4 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2021

  1. Merge branch 'main' of https://github.com/dotnet/runtime into wasm-no… 

    …de-flag
    @Daniel-Genkin
    Daniel-Genkin committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    488390d View commit details
    Browse the repository at this point in the history

  2. small fixes

    @Daniel-Genkin
    Daniel-Genkin committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    94883ca View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of https://github.com/dotnet/runtime into wasm-no… 

    …de-flag
    @Daniel-Genkin
    Daniel-Genkin committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    3cd1eaa View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2021

  1. Only generate run-v8 or run-node instead of both

    @Daniel-Genkin
    Daniel-Genkin committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    a542e6f View commit details
    Browse the repository at this point in the history

  2. added package.json to functional tests + removed node-fetch dependency

    @Daniel-Genkin
    Daniel-Genkin committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    ce1bf50 View commit details
    Browse the repository at this point in the history

  3. Fixed typo

    @Daniel-Genkin
    Daniel-Genkin committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    fd50498 View commit details
    Browse the repository at this point in the history

  4. Fixed script generation

    @Daniel-Genkin
    Daniel-Genkin committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    749dbe6 View commit details
    Browse the repository at this point in the history

  5. work in progress

    Daniel Genkin committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    902f8aa View commit details
    Browse the repository at this point in the history

  6. Create a package.json if one is needed but non existant

    Daniel Genkin committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    943afd5 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2021

  1. temporarily removed using node crypto as it breaks tests and reverted… 

    … to previous polyfill
    @Daniel-Genkin
    Daniel-Genkin committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    1a75b99 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2021

  1. Fixed some more tests on node

    @Daniel-Genkin
    Daniel-Genkin committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    3a7fd15 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2021

  1. Fixed building/publishing on latest Node and latest NPM + removed unn… 

    …ecessary dependencies
    @Daniel-Genkin
    Daniel-Genkin committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    f4f69fd View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2021

  1. Fixed some tests in node

    @Daniel-Genkin
    Daniel-Genkin committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    2ad29a0 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2021

  1. removed globalThis namespace from Module declaration

    @Daniel-Genkin
    Daniel-Genkin committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    cd4a7d3 View commit details
    Browse the repository at this point in the history

  2. attempt to add some new CI pipelines for NodeJS 

    + test build for NodeJS
+ test all subsets of tests
+ test EAT tests
+ test AOT tests
    @Daniel-Genkin
    Daniel-Genkin committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    68ef992 View commit details
    Browse the repository at this point in the history

  3. Fixed pipeline naming

    @Daniel-Genkin
    Daniel-Genkin committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    695fa9b View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2021

  1. updated to use new linux image with npm installed

    @Daniel-Genkin
    Daniel-Genkin committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    f3cfdd2 View commit details
    Browse the repository at this point in the history

  2. Updated linux image to correct version

    @Daniel-Genkin
    Daniel-Genkin committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    611ec16 View commit details
    Browse the repository at this point in the history

  3. added globalThis pollyfill on node to fix tests.

    @Daniel-Genkin
    Daniel-Genkin committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    7792bd3 View commit details
    Browse the repository at this point in the history

  4. Fixed dependency warnings

    @Daniel-Genkin
    Daniel-Genkin committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    c49737c View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2021

  1. cleanup to fix a few CI issues

    @Daniel-Genkin
    Daniel-Genkin committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    227e045 View commit details
    Browse the repository at this point in the history

  2. explicitly set all node dependencies + cleaned up dotnet.js file loading

    @Daniel-Genkin
    Daniel-Genkin committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    1e44529 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2021

  1. Created new NodeJS RunHost

    @Daniel-Genkin
    Daniel-Genkin committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    8be4c8d View commit details
    Browse the repository at this point in the history

  2. Updated some readmes, makefiles and other miscellaneous references to… 

    … v8 to also mention node
    @Daniel-Genkin
    Daniel-Genkin committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    06015b3 View commit details
    Browse the repository at this point in the history

  3. Fixed trailing spaces in markdown

    @Daniel-Genkin
    Daniel-Genkin committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    c9514a4 View commit details
    Browse the repository at this point in the history

  4. work in progress setting up RunHost

    @Daniel-Genkin
    Daniel-Genkin committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    7279a1f View commit details
    Browse the repository at this point in the history

  5. moved parenthesis

    @Daniel-Genkin
    Daniel-Genkin committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    b6e0cf4 View commit details
    Browse the repository at this point in the history

  6. work in progress dealing with tests

    @Daniel-Genkin
    Daniel-Genkin committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    461f531 View commit details
    Browse the repository at this point in the history

  7. Learned that you cannot nest itemGroups

    @Daniel-Genkin
    Daniel-Genkin committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    de94bb3 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2021

  1. Continued work on setting up green tests

    @Daniel-Genkin
    Daniel-Genkin committed Jul 10, 2021
    Configuration menu
    Copy the full SHA
    2e065ca View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2021

  1. continued work on setting up green tests

    @Daniel-Genkin
    Daniel-Genkin committed Jul 11, 2021
    Configuration menu
    Copy the full SHA
    f6beb45 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2021

  1. Moved disabling JIT tests into proper location + added other 2 failures

    @Daniel-Genkin
    Daniel-Genkin committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    c028ae9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/dotnet/runtime into wasm-no… 

    …de-flag
    @Daniel-Genkin
    Daniel-Genkin committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    f45b96e View commit details
    Browse the repository at this point in the history

  3. minor adjustments from merging with dotnet/runtime main branch

    @Daniel-Genkin
    Daniel-Genkin committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    87e6b09 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2021

  1. Tried yet again to disable the JIT tests

    @Daniel-Genkin
    Daniel-Genkin committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    caf4be3 View commit details
    Browse the repository at this point in the history

  2. Continued working on tests

    @Daniel-Genkin
    Daniel-Genkin committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    261356d View commit details
    Browse the repository at this point in the history

  3. work in progress

    @Daniel-Genkin
    Daniel-Genkin committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    3584849 View commit details
    Browse the repository at this point in the history

  4. work in progress for fixing JIT tests

    @Daniel-Genkin
    Daniel-Genkin committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    4be9563 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2021

  1. Continued work on fixing and or disabling the JIT tests

    @Daniel-Genkin
    Daniel-Genkin committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    bcf99af View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/dotnet/runtime into wasm-no… 

    …de-flag
    @Daniel-Genkin
    Daniel-Genkin committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    7db07e1 View commit details
    Browse the repository at this point in the history

  3. fixed the new indicator for run environment in runtime tests

    @Daniel-Genkin
    Daniel-Genkin committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    bd6af51 View commit details
    Browse the repository at this point in the history

  4. Since Wasm.Build.Tests are failing I uncommented the RebuildTests whi… 

    …ch were failing for the same reason + added a condition to runtime-test.js to make the issue more explicit.
    @Daniel-Genkin
    Daniel-Genkin committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    419c446 View commit details
    Browse the repository at this point in the history

  5. Attempt to fix JIT tests

    @Daniel-Genkin
    Daniel-Genkin committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    541b218 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' of https://github.com/dotnet/runtime into wasm-no… 

    …de-flag
    @Daniel-Genkin
    Daniel-Genkin committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    3adeed2 View commit details
    Browse the repository at this point in the history

  7. Attempt to fix ForNode being unset on helix

    @Daniel-Genkin
    Daniel-Genkin committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    339230d View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2021

  1. Fixed the WasmBuildTests

    @Daniel-Genkin
    Daniel-Genkin committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    a1d8139 View commit details
    Browse the repository at this point in the history

  2. Another attempt to fix the JIT tests (Thanks Ankit)

    @Daniel-Genkin
    Daniel-Genkin committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    f974ea6 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2021

  1. Passed ForNode to everything as an experiment

    @Daniel-Genkin
    Daniel-Genkin committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    4c2f5a8 View commit details
    Browse the repository at this point in the history

  2. Added ForNdoe into more msbuild property tags

    @Daniel-Genkin
    Daniel-Genkin committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    41d011d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'wasm-node-flag' of https://github.com/Daniel-Genkin/run… 

    …time into wasm-node-flag
    @Daniel-Genkin
    Daniel-Genkin committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    7805d93 View commit details
    Browse the repository at this point in the history

  4. Gradually adding more places where I pass the ForNode switch

    @Daniel-Genkin
    Daniel-Genkin committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    4cebd85 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2021

  1. yet another attempt to fix the JIT tests

    @Daniel-Genkin
    Daniel-Genkin committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    06fe9fd View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2021

  1. continued with JIT tests

    @Daniel-Genkin
    Daniel-Genkin committed Jul 18, 2021
    Configuration menu
    Copy the full SHA
    44dc557 View commit details
    Browse the repository at this point in the history

  2. Fixed circular dependency

    @Daniel-Genkin
    Daniel-Genkin committed Jul 18, 2021
    Configuration menu
    Copy the full SHA
    f2373bf View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2021

  1. another attempt to pass ForNode value to Helix

    @Daniel-Genkin
    Daniel-Genkin committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    d88650e View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2021

  1. undid previous commit and tried using runtime variables

    @Daniel-Genkin
    Daniel-Genkin committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    06d2a29 View commit details
    Browse the repository at this point in the history

  2. intentaionally broke CI to test a theory as to where ForNode is not… 

    … being passed
    @Daniel-Genkin
    Daniel-Genkin committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    14340fd View commit details
    Browse the repository at this point in the history

  3. removed hardcoded fornode value + disabled JIT tests due to intermitt… 

    …ent failure
    @Daniel-Genkin
    Daniel-Genkin committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    369d668 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2021

  1. Undid adding ForNode as local property to msbuild tasks

    @Daniel-Genkin
    Daniel-Genkin committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    eb06d5d View commit details
    Browse the repository at this point in the history

  2. emoved WBT tests - will re-add in later PR

    @Daniel-Genkin
    Daniel-Genkin committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    151b3fd View commit details
    Browse the repository at this point in the history

  3. Commented out remaining piece of WBT tests on Node

    @Daniel-Genkin
    Daniel-Genkin committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    6ddfb87 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2021

  1. made default packge.json use template file

    @Daniel-Genkin
    Daniel-Genkin committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    af9f2c7 View commit details
    Browse the repository at this point in the history

  2. Addressed PR comment - only define globalThis if it isn't defined

    @Daniel-Genkin
    Daniel-Genkin committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    24cf4b9 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of https://github.com/dotnet/runtime into wasm-no… 

    …de-flag
    @Daniel-Genkin
    Daniel-Genkin committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    4345ffb View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2021

  1. made ci use npm ci rather than install for speed and consistency

    @Daniel-Genkin
    Daniel-Genkin committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    fb84fd3 View commit details
    Browse the repository at this point in the history

  2. use emsdk npm for npm ci and npm install commands

    @Daniel-Genkin
    Daniel-Genkin committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    11f3bd9 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2021

  1. added Node debugging entrypoint and rudimentary setup

    @Daniel-Genkin
    Daniel-Genkin committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    1ca271d View commit details
    Browse the repository at this point in the history

  2. work in progress

    @Daniel-Genkin
    Daniel-Genkin committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    eaaea18 View commit details
    Browse the repository at this point in the history

  3. Fixed the issue with paths being formatted incorrectly

    @Daniel-Genkin
    Daniel-Genkin committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    8c7d0aa View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2021

  1. Minor cleanup

    @Daniel-Genkin
    Daniel-Genkin committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    8ec8967 View commit details
    Browse the repository at this point in the history

  2. removed debugging modifications from console sample + aded documentation

    @Daniel-Genkin
    Daniel-Genkin committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    9740e78 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2021

  1. Pegged node dependency verssus for extra security. I ran an npm audit… 

    … on this configuration and 0 vulnerabilities were found
    @Daniel-Genkin
    Daniel-Genkin committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    fe7d0f7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/dotnet/runtime into wasm-no… 

    …de-debugger
    @Daniel-Genkin
    Daniel-Genkin committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    d02c95e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of https://github.com/dotnet/runtime into wasm-no… 

    …de-flag
    @Daniel-Genkin
    Daniel-Genkin committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    50b6e2e View commit details
    Browse the repository at this point in the history

  4. Merge branch 'wasm-node-flag' into wasm-node-debugger

    @Daniel-Genkin
    Daniel-Genkin committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    507ba89 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2021

  1. attempt to add a supported version of node to the correlation payload… 

    … and use it for the node tests
    @Daniel-Genkin
    Daniel-Genkin committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    105b005 View commit details
    Browse the repository at this point in the history

  2. fixed syntax error

    @Daniel-Genkin
    Daniel-Genkin committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    096aee8 View commit details
    Browse the repository at this point in the history

  3. Fixed typo that broke tests

    @Daniel-Genkin
    Daniel-Genkin committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    7da1413 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2021

  1. undid experiments with using emsdk's node

    @Daniel-Genkin
    Daniel-Genkin committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    1ed87a1 View commit details
    Browse the repository at this point in the history

  2. Attempt to download the tar file manually and include as a local file… 

    … to the Helix payload
    @Daniel-Genkin
    Daniel-Genkin committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    48f902c View commit details
    Browse the repository at this point in the history

  3. fixed msbuild parsing issue

    @Daniel-Genkin
    Daniel-Genkin committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    327948e View commit details
    Browse the repository at this point in the history

  4. wrapped HelixCorrelationPayload in itemgroup

    @Daniel-Genkin
    Daniel-Genkin committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    4178b5b View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2021

  1. adjusted paths to make export PATH work

    @Daniel-Genkin
    Daniel-Genkin committed Aug 3, 2021
    Configuration menu
    Copy the full SHA
    c9f326a View commit details
    Browse the repository at this point in the history

  2. Fix how to connect to node. 

    Fix how to get assembly metadata.
    @thaystg
    thaystg committed Aug 3, 2021
    Configuration menu
    Copy the full SHA
    97a4412 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of https://github.com/dotnet/runtime into wasm-no… 

    …de-debugger
    @Daniel-Genkin
    Daniel-Genkin committed Aug 3, 2021
    Configuration menu
    Copy the full SHA
    5f3a44c View commit details
    Browse the repository at this point in the history

  4. Merge branch 'wasm-node-debugger' of https://github.com/Daniel-Genkin… 

    …/runtime into wasm-node-debugger
    @Daniel-Genkin
    Daniel-Genkin committed Aug 3, 2021
    Configuration menu
    Copy the full SHA
    79c8ccc View commit details
    Browse the repository at this point in the history

  5. attempt to fix runtime tests on node not having ForNode property set … 

    …properly
    @Daniel-Genkin
    Daniel-Genkin committed Aug 3, 2021
    Configuration menu
    Copy the full SHA
    75aba80 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'wasm-node-flag' of https://github.com/Daniel-Genkin/run… 

    …time into wasm-node-debugger
    @Daniel-Genkin
    Daniel-Genkin committed Aug 3, 2021
    Configuration menu
    Copy the full SHA
    6a4e119 View commit details
    Browse the repository at this point in the history

  7. Finally fixed the issue with /ForNode=true not being pased to runtime… 

    … tests
    @Daniel-Genkin
    Daniel-Genkin committed Aug 3, 2021
    Configuration menu
    Copy the full SHA
    49059f9 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2021

  1. added manual node downloading when publishing helix with arcade

    @Daniel-Genkin
    Daniel-Genkin committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    c87fd0f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/dotnet/runtime into wasm-no… 

    …de-flag
    @Daniel-Genkin
    Daniel-Genkin committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    d71a614 View commit details
    Browse the repository at this point in the history

  3. Another attempt to add node to correlation payload without depending … 

    …on helix sdk
    @Daniel-Genkin
    Daniel-Genkin committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    5dc268c View commit details
    Browse the repository at this point in the history

  4. Cleaned up paths and made sure to only send the useful files to Helix

    @Daniel-Genkin
    Daniel-Genkin committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    8f94e88 View commit details
    Browse the repository at this point in the history

  5. apparently Copy can only copy files

    @Daniel-Genkin
    Daniel-Genkin committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    801c79b View commit details
    Browse the repository at this point in the history

  6. fixed embarassing accident which broke WasmBuildTests

    @Daniel-Genkin
    Daniel-Genkin committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    1d279d5 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'wasm-node-flag' of https://github.com/Daniel-Genkin/run… 

    …time into wasm-node-debugger
    @Daniel-Genkin
    Daniel-Genkin committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    65aa306 View commit details
    Browse the repository at this point in the history