[release/6.0-rc2] [iOS] Make sure IPGlobalProperties and NetworkInterface.GetIsNetworkAvailable methods return the correct info #59258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
added 2 commits
September 17, 2021 12:51
…vailable methods return the correct info This change makes sure some of the IPGlobalProperties stop throwing exceptions and return the correct values. - GetIPv4GlobalStatistics, GetIcmpV4Statistics, GetTcpIPv4Statistics, GetUdpIPv4Statistics no longer throw NetworkInformationException. - GetActiveTcpConnections no longer returns TcpConnectionInformation instances only with the State of Unknown. - GetActiveTcpListeners return the correct IPEndPoint details for the IPV6 loopback. - NetworkInterface.GetIsNetworkAvailable no longer returns false for every call. The reason these methods were behaving incorrectly on iOS is due to Apple not including the public headers for icmp_var.h, ip_var.h, tcp_fsm.h, if_media.h, and udp_var.h in the iOS SDK. This would lead to, for example, pal_tcpstate.c always returning TcpState_Unknown even if the underlying native value was TCPS_ESTABLISHED. This change includes the missing public headers in our build. Fixes #36890
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsBackport of #57096 to release/6.0-rc2 /cc @steveisok Customer ImpactTestingRisk
|
jamshedd
added
Servicing-approved
steveisok
approved these changes
Sep 21, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #57096 to release/6.0-rc2
/cc @steveisok
Customer Impact
Some IPGlobalProperties and NetworkInterface methods were throwing exceptions or returning incomplete data on iOS. The customer impact is that they can now rely on these methods to return the right information.
Testing
There were a handful of libraries tests that were previously failing that now pass
Risk
Minimal