Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reciprocal and SinCos methods to IFloatingPoint #59521

Merged
merged 8 commits into from
Mar 27, 2022
Merged

Add reciprocal and SinCos methods to IFloatingPoint #59521

merged 8 commits into from
Mar 27, 2022

Conversation

i3arnon
Copy link
Contributor

@i3arnon i3arnon commented Sep 23, 2021

Fix #58607

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Sep 23, 2021
@ghost
Copy link

ghost commented Sep 23, 2021

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #58607

Author: i3arnon
Assignees: -
Labels:

area-System.Numerics, community-contribution
Milestone: -

@runfoapp runfoapp bot mentioned this pull request Sep 24, 2021
Closed
@tannergooding
Copy link
Member

@i3arnon, sorry for the delay.

All the changes look good but there appear to be a few merge conflicts present. Could you resolve those? This should be mergeable once that is complete.

@jeffhandley
Copy link
Member

Tagged as 'needs more info' to capture that the conflicts need to be resolved.

@tannergooding
Copy link
Member

@i3arnon are you still working on this?

No particular rush, just wanted to ensure that was the case since many people took a break over the holidays. There are still pending comments above that would need to be resolved.

@tannergooding tannergooding added needs-author-action An issue or pull request that requires more info or actions from the author. and removed needs more info labels Jan 7, 2022
@ghost ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Jan 12, 2022
@i3arnon
Copy link
Contributor Author

i3arnon commented Jan 12, 2022

@tannergooding I solved the conflicts. Sorry for the delay..

@tannergooding
Copy link
Member

Sorry for the delay. This was blocked/delayed while we worked through various other issues involving generic math and prepping it for .NET 7.

All those issues have now been resolved and we can merge this.

There are, unfortunately, some more conflicts. These are a side effect of other PRs also being unblocked and the interfaces now being "implicitly", rather than "explicitly", implemented.

If you're otherwise busy, I can push up fixes for the conflicts here.

@i3arnon
Copy link
Contributor Author

i3arnon commented Mar 24, 2022

@tannergooding I fixed the conflicts.

@danmoseley danmoseley merged commit ef4773c into dotnet:main Mar 27, 2022
@danmoseley
Copy link
Member

Thanks @i3arnon

radekdoulik pushed a commit to radekdoulik/runtime that referenced this pull request Mar 30, 2022
@i3arnon @radekdoulik
Add reciprocal and SinCos methods to IFloatingPoint (dotnet#59521)
c9f8f70
@ghost ghost locked as resolved and limited conversation to collaborators Apr 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tannergooding tannergooding tannergooding approved these changes

Assignees

@tannergooding tannergooding

Labels
area-System.Numerics community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add reciprocal and SinCos methods to IFloatingPoint
4 participants
@i3arnon @tannergooding @jeffhandley @danmoseley