Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-enable and fix the SetOutReadToEnd test #62200

Merged
merged 1 commit into from
Dec 1, 2021
Merged

re-enable and fix the SetOutReadToEnd test #62200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/System.Console/tests/SetOut.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
using System.IO;
using Xunit;

[Collection(nameof(DisableParallelization))] // Console.Out is a static singleton, other tests should not be using it at the same time
public class SetOut
{
[Fact]
Expand All @@ -28,7 +29,6 @@ public static void SetOutReadLine()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/57935", TestPlatforms.AnyUnix)]
public static void SetOutReadToEnd()
{
Helpers.SetAndReadHelper(tw => Console.SetOut(tw), () => Console.Out, sr => sr.ReadToEnd());
Expand Down
2 changes: 2 additions & 0 deletions src/libraries/System.Console/tests/System.Console.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@
Link="Common\System\IO\InterceptStreamWriter.cs" />
<Compile Include="$(CommonTestPath)System\ShouldNotBeInvokedException.cs"
Link="Common\System\ShouldNotBeInvokedException.cs" />
<Compile Include="$(CommonTestPath)TestUtilities\System\DisableParallelization.cs"
Link="Common\TestUtilities\System\DisableParallelization.cs" />
<Compile Include="WindowAndCursorProps.cs" />
</ItemGroup>
<ItemGroup>
Expand Down