Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable package validation in source-build for reliability #63601

Closed
wants to merge 1 commit into from

Conversation

lbussell
Copy link
Contributor

@lbussell lbussell commented Jan 11, 2022

See dotnet/source-build#2708: The source-build team is making an effort to upstream all of our patches over the next week.

This is a port of #60881 to main. Description from the comment in the diff:

Package validation causes flaky errors during the build. Validation isn't useful during
source-build (it is only a guardrail for devs), so disable it during source-build to avoid the
impact on build reliability. https://github.com/dotnet/runtime/issues/60883 tracks fixing the
flakiness and removing this condition.

@ghost
Copy link

ghost commented Jan 11, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

This is a port of #60881 to main. Description from the comment in the diff:

Package validation causes flaky errors during the build. Validation isn't useful during
source-build (it is only a guardrail for devs), so disable it during source-build to avoid the
impact on build reliability. https://github.com/dotnet/runtime/issues/60883 tracks fixing the
flakiness and removing this condition.

Author: lbussell
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@safern
Copy link
Member

safern commented Jan 11, 2022

@lbussell just curious, why is this needed in main? We fixed the reliability issues we were hitting on PackageValidation on main already and we haven't seen this error in months on the dotnet/runtime main branch.

@lbussell
Copy link
Contributor Author

just curious, why is this needed in main? We fixed the reliability issues

Oh, I see, I didn't catch that the reliability issue has been fixed in main. We're still carrying a patch for this change in source build on installer/main, so I assumed this change was necessary. I'll give a shot at deleting the patch and if it's reliable, I'll close this PR.

@safern
Copy link
Member

safern commented Jan 11, 2022

Thanks!

@lbussell lbussell closed this Jan 11, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Feb 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants