-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Perf][Maui] Set only android-arm64 to be built for Maui #65747
[Perf][Maui] Set only android-arm64 to be built for Maui #65747
Conversation
Tagging subscribers to this area: @hoyosjs Issue DetailsThis makes it so we only build a single architecture (android-arm64) specifically for size on disk testing and seeing what a single target device would download. This is a part of dotnet/performance#2229. Reason for splitting of dotnet restore out of the install is dotnet/sdk#21877. Pipeline was successfully run using main perf repo.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -129,8 +129,9 @@ steps: | |||
|
|||
- script: | | |||
chmod -R a+r . | |||
../dotnet publish -bl:MauiAndroid.binlog -f net6.0-android -c Release | |||
mv ./bin/Release/net6.0-android/com.companyname.MauiTesting-Signed.apk ./MauiAndroidDefault.apk | |||
../dotnet restore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment with a link to the issue we are working around here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this one, dotnet/sdk#21877.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment in the code with a link to the issue we are working around here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, yes
../dotnet publish -bl:MauiAndroid.binlog -f net6.0-android -c Release | ||
mv ./bin/Release/net6.0-android/com.companyname.MauiTesting-Signed.apk ./MauiAndroidDefault.apk | ||
../dotnet restore | ||
../dotnet publish -bl:MauiAndroid.binlog -f net6.0-android -c Release -r android-arm64 --no-restore --self-contained |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--self-contained
shouldn't be needed. dotnet/sdk#23705 is now closed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, I will try it without it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this pipeline is using the .NET 6.0.200 SDK, it looks like it is fixed in 6.0.300.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be using the latest SDK.... whatever our customers will be using.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'll let Parker know when it's time to switch.
We're currently blocked on some missing dotnet/linker changes: dotnet/android#6742
This makes it so we only build a single architecture (android-arm64) specifically for size on disk testing and seeing what a single target device would download. This is a part of dotnet/performance#2229. Reason for splitting of dotnet restore out of the install is dotnet/sdk#21877. Pipeline was successfully run using main perf repo.