Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf][Maui] Set only android-arm64 to be built for Maui #65747

Merged
merged 4 commits into from
Feb 25, 2022

Conversation

LoopedBard3
Copy link
Member

This makes it so we only build a single architecture (android-arm64) specifically for size on disk testing and seeing what a single target device would download. This is a part of dotnet/performance#2229. Reason for splitting of dotnet restore out of the install is dotnet/sdk#21877. Pipeline was successfully run using main perf repo.

@ghost
Copy link

ghost commented Feb 22, 2022

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

This makes it so we only build a single architecture (android-arm64) specifically for size on disk testing and seeing what a single target device would download. This is a part of dotnet/performance#2229. Reason for splitting of dotnet restore out of the install is dotnet/sdk#21877. Pipeline was successfully run using main perf repo.

Author: LoopedBard3
Assignees: LoopedBard3
Labels:

area-Infrastructure-coreclr

Milestone: -

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -129,8 +129,9 @@ steps:

- script: |
chmod -R a+r .
../dotnet publish -bl:MauiAndroid.binlog -f net6.0-android -c Release
mv ./bin/Release/net6.0-android/com.companyname.MauiTesting-Signed.apk ./MauiAndroidDefault.apk
../dotnet restore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment with a link to the issue we are working around here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this one, dotnet/sdk#21877.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment in the code with a link to the issue we are working around here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yes

../dotnet publish -bl:MauiAndroid.binlog -f net6.0-android -c Release
mv ./bin/Release/net6.0-android/com.companyname.MauiTesting-Signed.apk ./MauiAndroidDefault.apk
../dotnet restore
../dotnet publish -bl:MauiAndroid.binlog -f net6.0-android -c Release -r android-arm64 --no-restore --self-contained
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--self-contained shouldn't be needed. dotnet/sdk#23705 is now closed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I will try it without it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this pipeline is using the .NET 6.0.200 SDK, it looks like it is fixed in 6.0.300.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be using the latest SDK.... whatever our customers will be using.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'll let Parker know when it's time to switch.

We're currently blocked on some missing dotnet/linker changes: dotnet/android#6742

@LoopedBard3 LoopedBard3 merged commit e27f594 into dotnet:main Feb 25, 2022
@LoopedBard3 LoopedBard3 deleted the MauiAndroidOnlyBuildARM64 branch March 1, 2022 00:09
@ghost ghost locked as resolved and limited conversation to collaborators Mar 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants