Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nullable annotations for System.Security.Cryptography.Xml #67198

Merged
merged 67 commits into from
Sep 27, 2022
Merged

Nullable annotations for System.Security.Cryptography.Xml #67198

merged 67 commits into from
Sep 27, 2022

Commits on Sep 3, 2022

  1. First pass

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    1707477 View commit details
    Browse the repository at this point in the history

  2. More annotations

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    431c22e View commit details
    Browse the repository at this point in the history

  3. Rever mistaken change to test

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    7146969 View commit details
    Browse the repository at this point in the history

  4. More annotations

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    e3d32f5 View commit details
    Browse the repository at this point in the history

  5. More annotations

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    78c8114 View commit details
    Browse the repository at this point in the history

  6. More annotations

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    cfe5c9d View commit details
    Browse the repository at this point in the history

  7. More annotations

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    c8a3983 View commit details
    Browse the repository at this point in the history

  8. More annotations

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    a5a1085 View commit details
    Browse the repository at this point in the history

  9. More annotations

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    9be11d8 View commit details
    Browse the repository at this point in the history

  10. More annotations

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    7d4b1ae View commit details
    Browse the repository at this point in the history

  11. More annotations

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    f9e3066 View commit details
    Browse the repository at this point in the history

  12. More annotations

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    79d8688 View commit details
    Browse the repository at this point in the history

  13. More annotations

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    71db6e3 View commit details
    Browse the repository at this point in the history

  14. More annotations

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    408d355 View commit details
    Browse the repository at this point in the history

  15. More annotations

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    d32935d View commit details
    Browse the repository at this point in the history

  16. Remove red flag comment

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    5b35583 View commit details
    Browse the repository at this point in the history

  17. PR feedback

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    e4d3350 View commit details
    Browse the repository at this point in the history

  18. Remove 'red flag' comments

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    1f75d3c View commit details
    Browse the repository at this point in the history

  19. Revert unintended changes to tests

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    753b05f View commit details
    Browse the repository at this point in the history

  20. Revert unintended changes

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    fd784fb View commit details
    Browse the repository at this point in the history

  21. PR feedback: remove redundant !'s from things that can never return null

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    3419961 View commit details
    Browse the repository at this point in the history

  22. Added [MemberNotNullWhen(true, nameof(_cachedXml))] on implementation.

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    d3180bb View commit details
    Browse the repository at this point in the history

  23. Updated ref t ypes (with `dotnet msbuild /t:GenerateReferenceAssembly… 

    …Source`)
    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    29f13a6 View commit details
    Browse the repository at this point in the history

  24. Updated ref assembly

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    a3d906a View commit details
    Browse the repository at this point in the history

  25. PR feedback: add MemberNotNull attribute on Initialize)

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    fdb26d4 View commit details
    Browse the repository at this point in the history

  26. Updated ref again

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    fe764fa View commit details
    Browse the repository at this point in the history

  27. Put MemberNotNull attribute on the getter rather than the property … 

    …in the reference file.
    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    86e1784 View commit details
    Browse the repository at this point in the history

  28. PR feedback: remove MemberNotNullWhenAttribute from ref

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    d76993c View commit details
    Browse the repository at this point in the history

  29. PR feedback: non nullable param to match method in base class

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    f4acf19 View commit details
    Browse the repository at this point in the history

  30. Fix post-merge build errors

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    295698d View commit details
    Browse the repository at this point in the history

  31. PR feedback

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    c394bc0 View commit details
    Browse the repository at this point in the history

  32. PR feedback from @bartonjs - add [DisallowNull] and cascade

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    917af63 View commit details
    Browse the repository at this point in the history

  33. PR feedback

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    3ee8598 View commit details
    Browse the repository at this point in the history

  34. PR feedback

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    c332f84 View commit details
    Browse the repository at this point in the history

  35. PR feedback

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    e29fc43 View commit details
    Browse the repository at this point in the history

  36. Fix build again, by removing the protected internal property `Cache… 

    …Valid`
    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    67bd994 View commit details
    Browse the repository at this point in the history

  37. PR feedback

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    ccb6a3f View commit details
    Browse the repository at this point in the history

  38. Added back CacheValid based on PR comment

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    e13afbf View commit details
    Browse the repository at this point in the history

  39. Fix issues from recent rebase

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    ee8a0aa View commit details
    Browse the repository at this point in the history

  40. Add DisallowNull attribute to ref file and remove it from `DefaultG… 

    …enApiDocIds.txt`
    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    987940a View commit details
    Browse the repository at this point in the history

  41. PR feedback

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    11dfa6d View commit details
    Browse the repository at this point in the history

  42. Fix issues from recent merge

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    9e65051 View commit details
    Browse the repository at this point in the history

  43. Remove some more extraneous damnit operators

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    7f0dcd0 View commit details
    Browse the repository at this point in the history

  44. Fix NRT analysis errors after prior rebase

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    836f21c View commit details
    Browse the repository at this point in the history

  45. PR feedback

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    943a5d6 View commit details
    Browse the repository at this point in the history

  46. PR feedback

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    f3a4984 View commit details
    Browse the repository at this point in the history

  47. PR feedback

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    11fac03 View commit details
    Browse the repository at this point in the history

  48. PR feedback

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    321e958 View commit details
    Browse the repository at this point in the history

  49. PR feedback

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    9418cf3 View commit details
    Browse the repository at this point in the history

  50. CipherReference and CipherValue made to disallow null

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    3324d39 View commit details
    Browse the repository at this point in the history

  51. Make Uri non-nullable on EnctrypedReference

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    e4af751 View commit details
    Browse the repository at this point in the history

  52. Add AllowNull attribute on EncryptedType::KeyInfo

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    2642850 View commit details
    Browse the repository at this point in the history

  53. AllowNull on EncryptedXml::Recipient

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    98a6572 View commit details
    Browse the repository at this point in the history

  54. Made baseUri nullable

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    9c033c7 View commit details
    Browse the repository at this point in the history

  55. DisallowNull on PropertlyElement

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    0ce398f View commit details
    Browse the repository at this point in the history

  56. AllowNull on SignedInfo::CanonicalizationMethod

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    fe63a28 View commit details
    Browse the repository at this point in the history

  57. AllowNull on SignedXml::EncryptedXml

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    03f8452 View commit details
    Browse the repository at this point in the history

  58. Fix build after recent rebase

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    2866e92 View commit details
    Browse the repository at this point in the history

  59. Remove redundant damnit operator now that dotnet#71860 has been merged

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    5a24eae View commit details
    Browse the repository at this point in the history

  60. PR feedback

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    8e00c00 View commit details
    Browse the repository at this point in the history

  61. Fix build due to change of the CanonicalXmlElement constructor

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    c3bbe9e View commit details
    Browse the repository at this point in the history

  62. PR feedback

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    7b1ca68 View commit details
    Browse the repository at this point in the history

  63. Remove redundant damnit operators

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    f47ad41 View commit details
    Browse the repository at this point in the history

  64. Fix broken tests

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    e952d69 View commit details
    Browse the repository at this point in the history

  65. Fix issues after rebase

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    32bb40d View commit details
    Browse the repository at this point in the history

  66. PR feedback

    @SteveDunn
    SteveDunn committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    9fda330 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2022

  1. PR feedback

    @SteveDunn
    SteveDunn committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    e768859 View commit details
    Browse the repository at this point in the history