Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TlsAlertMessage enum to make exception messages more readable #72370

Conversation

rzikm
Copy link
Member

@rzikm rzikm commented Jul 18, 2022

Closes #72368.

TlsAlertMessage.cs was moved to shared (Common) sources and is used for both System.Net.Security and System.Net.Quic. This makes the TLS Alert-related exception messages consistent between SslStream and QuicConnection.

@ghost
Copy link

ghost commented Jul 18, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Closes #72368.

TlsAlertMessage.cs was moved to shared (Common) sources and is used for both System.Net.Security and System.Net.Quic. This makes the TLS Alert-related exception messages consistent between SslStream and QuicConnection.

Author: rzikm
Assignees: -
Labels:

area-System.Net

Milestone: -

@rzikm rzikm requested a review from ManickaP July 18, 2022 11:57
Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! That was super fast 😃

@rzikm rzikm merged commit c0ddf0f into dotnet:main Jul 19, 2022
@karelz karelz added this to the 7.0.0 milestone Jul 19, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QUIC] Improve AuthenticationException error message
4 participants