Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm][debugger] Fix debugger behavior when the type has ToString method overridden #76780

Merged
merged 11 commits into from
Oct 11, 2022
Merged

[wasm][debugger] Fix debugger behavior when the type has ToString method overridden #76780

merged 11 commits into from
Oct 11, 2022

Commits on Oct 8, 2022

  1. The description of an object that has ToString implemented should be … 

    …the result of the ToString and not the type name.
    @thaystg
    thaystg committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    62d86f2 View commit details
    Browse the repository at this point in the history

  2. Fix if cannot find ToString method.

    @thaystg
    thaystg committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    0c124b8 View commit details
    Browse the repository at this point in the history

  3. removing my name of the code

    @thaystg
    thaystg committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    8dcd0d4 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2022

  1. Implementing support for inherited classes with ToString overriden. 

    Implement support for value types with ToString overriden.
Fix Debugger* is more relevant than ToString
    @thaystg
    thaystg committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    87fc1a3 View commit details
    Browse the repository at this point in the history

  2. Fix test cases.

    @thaystg
    thaystg committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    eabbc6b View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Ankit Jain <radical@gmail.com>
    @thaystg @radical
    thaystg and radical committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    7d9698a View commit details
    Browse the repository at this point in the history

  2. Adding more tests and addressing @radical comments

    @thaystg
    thaystg committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    451b4ec View commit details
    Browse the repository at this point in the history

  3. Adding tests for record

    @thaystg
    thaystg committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    eadebf0 View commit details
    Browse the repository at this point in the history

  4. Moving implementation of InvokeToStringAsync to sdbhelper and reuse i… 

    …t on objects and valuetypes.
    @thaystg
    thaystg committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    99b2429 View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Ankit Jain <radical@gmail.com>
    @thaystg @radical
    thaystg and radical committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    d11ed8f View commit details
    Browse the repository at this point in the history

  6. Addressing @radical comments.

    @thaystg
    thaystg committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    794a460 View commit details
    Browse the repository at this point in the history