Fix gc hole in Frozen.cs #76868
Merged
Fix gc hole in Frozen.cs #76868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/gc |
EgorBo
force-pushed
the
fix-gc-hole-frozen
branch
from
6cf8a07
to
d6f1257
Compare
jkotas
reviewed
Oct 11, 2022
jkotas
reviewed
Oct 11, 2022
src/tests/GC/API/Frozen/Frozen.cs
Outdated
| ref Unsafe.As<RawData>(obj).Data; | ||
|
|
||
| internal static unsafe IntPtr GetMethodTablePointer(object obj) => | ||
| (IntPtr)Unsafe.Add(ref Unsafe.As<byte, IntPtr>(ref obj.GetRawData()), -1); |
There was a problem hiding this comment.
This assumes that offset 0 is a valid byref. It happens to be true in CoreCLR today, but it is not a safe assumption to make.
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
This was referenced Oct 11, 2022
Closed
jkotas
approved these changes
Oct 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76856
Confirmed that the test stopped crashing after this change.