Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fold bound checks for static readonly arrays/strings #77593

Merged
merged 44 commits into from
Nov 1, 2022
Merged

Fold bound checks for static readonly arrays/strings #77593

merged 44 commits into from
Nov 1, 2022

Commits on Oct 29, 2022

  1. Initial impl of Jan's suggestions

    @EgorBo
    EgorBo committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    0fe7042 View commit details
    Browse the repository at this point in the history

  2. Address part of the feedback

    @EgorBo
    EgorBo committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    e428363 View commit details
    Browse the repository at this point in the history

  3. Address feedback

    @EgorBo
    EgorBo committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    774af69 View commit details
    Browse the repository at this point in the history

  4. Remove "is frozen" check from jit

    @EgorBo
    EgorBo committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    28b9be3 View commit details
    Browse the repository at this point in the history

  5. NativeAOT support

    @EgorBo
    EgorBo committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    9f92bfb View commit details
    Browse the repository at this point in the history

  6. Use CORINFO_OBJECT_HANDLE in more places

    @EgorBo
    EgorBo committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    687d5cb View commit details
    Browse the repository at this point in the history

  7. Free jit handles upon exit

    @EgorBo
    EgorBo committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    872058d View commit details
    Browse the repository at this point in the history

  8. Update src/coreclr/vm/jitinterface.cpp 

    Co-authored-by: Jan Kotas <jkotas@microsoft.com>
    @EgorBo @jkotas
    EgorBo and jkotas committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    860d706 View commit details
    Browse the repository at this point in the history

  9. Clean up

    @EgorBo
    EgorBo committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    bffb8e6 View commit details
    Browse the repository at this point in the history

  10. clean up in getArrayLength

    @EgorBo
    EgorBo committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    f0a35cc View commit details
    Browse the repository at this point in the history

  11. Update jitinterface.h

    @EgorBo
    EgorBo committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    bfaf6ee View commit details
    Browse the repository at this point in the history

  12. Remove unnecessary DestroyHandle

    @EgorBo
    EgorBo committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    a3ccc91 View commit details
    Browse the repository at this point in the history

  13. Rename to getArrayOrStringLength, free jit handles in destructor

    @EgorBo
    EgorBo committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    7e041c1 View commit details
    Browse the repository at this point in the history

  14. fix compilation

    @EgorBo
    EgorBo committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    1bba1ec View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2022

  1. Use IND instead of LoadVector

    @EgorBo
    EgorBo committed Oct 30, 2022
    Configuration menu
    Copy the full SHA
    ee0117e View commit details
    Browse the repository at this point in the history

  2. Update hwintrinsicxarch.cpp

    @EgorBo
    EgorBo committed Oct 30, 2022
    Configuration menu
    Copy the full SHA
    b20f1fb View commit details
    Browse the repository at this point in the history

  3. Update hwintrinsicxarch.cpp

    @EgorBo
    EgorBo committed Oct 30, 2022
    Configuration menu
    Copy the full SHA
    2a12b10 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Jan Kotas <jkotas@microsoft.com>
    @EgorBo @jkotas
    EgorBo and jkotas committed Oct 30, 2022
    Configuration menu
    Copy the full SHA
    504acf3 View commit details
    Browse the repository at this point in the history

  5. Address feedback

    @EgorBo
    EgorBo committed Oct 30, 2022
    Configuration menu
    Copy the full SHA
    b56a67f View commit details
    Browse the repository at this point in the history

  6. Address feedback

    @EgorBo
    EgorBo committed Oct 30, 2022
    Configuration menu
    Copy the full SHA
    15a39a6 View commit details
    Browse the repository at this point in the history

  7. Address feedback

    @EgorBo
    EgorBo committed Oct 30, 2022
    Configuration menu
    Copy the full SHA
    1683f29 View commit details
    Browse the repository at this point in the history

  8. Move "Is frozen" check to getJitHandleForObject

    @EgorBo
    EgorBo committed Oct 30, 2022
    Configuration menu
    Copy the full SHA
    43a32c9 View commit details
    Browse the repository at this point in the history

  9. Update src/coreclr/vm/jitinterface.cpp 

    Co-authored-by: Jan Kotas <jkotas@microsoft.com>
    @EgorBo @jkotas
    EgorBo and jkotas committed Oct 30, 2022
    Configuration menu
    Copy the full SHA
    d10f4eb View commit details
    Browse the repository at this point in the history

  10. Update src/coreclr/vm/jitinterface.cpp 

    Co-authored-by: Jan Kotas <jkotas@microsoft.com>
    @EgorBo @jkotas
    EgorBo and jkotas committed Oct 30, 2022
    Configuration menu
    Copy the full SHA
    4443383 View commit details
    Browse the repository at this point in the history

  11. use OBJECTREF everywhere

    @EgorBo
    EgorBo committed Oct 30, 2022
    Configuration menu
    Copy the full SHA
    429b4d1 View commit details
    Browse the repository at this point in the history

  12. fix bad merge

    @EgorBo
    EgorBo committed Oct 30, 2022
    Configuration menu
    Copy the full SHA
    49c32c4 View commit details
    Browse the repository at this point in the history

  13. Cannonize more loads

    @EgorBo
    EgorBo committed Oct 30, 2022
    Configuration menu
    Copy the full SHA
    5dbbef4 View commit details
    Browse the repository at this point in the history

  14. check ISAs

    @EgorBo
    EgorBo committed Oct 30, 2022
    Configuration menu
    Copy the full SHA
    62f5cbb View commit details
    Browse the repository at this point in the history

  15. Fix comments

    @EgorBo
    EgorBo committed Oct 30, 2022
    Configuration menu
    Copy the full SHA
    a096211 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2022

  1. Handle stores

    @EgorBo
    EgorBo committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    efd71e9 View commit details
    Browse the repository at this point in the history

  2. Fix compilation & address feedback around redundant IsFrozenSegment call

    @EgorBo
    EgorBo committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    27a2619 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'use-ind-for-loads' of github.com:EgorBo/runtime-1 into … 

    …fold-static-readonly-array-length
    @EgorBo
    EgorBo committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    1f95212 View commit details
    Browse the repository at this point in the history

  4. DescriptionDescription -> Description

    @EgorBo
    EgorBo committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    d5c3cab View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' of github.com:dotnet/runtime into fold-static-rea… 

    …donly-array-length
    @EgorBo
    EgorBo committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    7621045 View commit details
    Browse the repository at this point in the history

  6. Update valuenum.cpp

    @EgorBo
    EgorBo committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    96397b1 View commit details
    Browse the repository at this point in the history

  7. Add comments

    @EgorBo
    EgorBo committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    076d4cd View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' of github.com:dotnet/runtime into fold-static-rea… 

    …donly-array-length
    @EgorBo
    EgorBo committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    1ecceca View commit details
    Browse the repository at this point in the history

  9. Revert unrelated SIMD changes (accidentally pushed)

    @EgorBo
    EgorBo committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    752c840 View commit details
    Browse the repository at this point in the history

  10. Use Exception sets

    @EgorBo
    EgorBo committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    ea8e369 View commit details
    Browse the repository at this point in the history

  11. Address feedback

    @EgorBo
    EgorBo committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    2fab46b View commit details
    Browse the repository at this point in the history

  12. Address feedback

    @EgorBo
    EgorBo committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    07d42e5 View commit details
    Browse the repository at this point in the history

  13. Update src/coreclr/jit/valuenum.cpp 

    Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>
    @EgorBo @SingleAccretion
    EgorBo and SingleAccretion committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    8c2ec20 View commit details
    Browse the repository at this point in the history

  14. Address feedback

    @EgorBo
    EgorBo committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    93c11c9 View commit details
    Browse the repository at this point in the history

  15. Apply suggestions from code review 

    Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>
    @EgorBo @SingleAccretion
    EgorBo and SingleAccretion committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    19df3e6 View commit details
    Browse the repository at this point in the history