Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in fixer on certain invalid patterns #80007

Merged
merged 10 commits into from
Jan 5, 2023

Conversation

danmoseley
Copy link
Member

@danmoseley danmoseley commented Dec 28, 2022

Fix #80004

  1. Add failing test and make fix.
  2. Tweak two strings.

Edit: actually several. I see no reason why double backslashes are in the strings, they appear literally in the exception messages. Fixed them all.

@ghost
Copy link

ghost commented Dec 28, 2022

Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #80004

  1. Add failing test and make fix.
  2. Tweak two strings.
Author: danmoseley
Assignees: -
Labels:

area-System.Text.RegularExpressions

Milestone: -

@build-analysis build-analysis bot mentioned this pull request Dec 28, 2022
@danmoseley
Copy link
Member Author

Failure is known and not relevant.

@danmoseley
Copy link
Member Author

of the failures both WASM

https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-80007-merge-1b7fbe7a837c425684/normal-System.Runtime.Tests/1/console.3b695942.log?helixlogtype=result is another instance of #79874

the other is a timeout https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-80007-merge-351a8f2b805347769a/WasmTestOnBrowser-System.Runtime.Tests/1/console.708fc41e.log?helixlogtype=result

[05:33:21] info: Initializing dotnet version 8.0.0-ci commit hash 5bb27278b4849e929ed6e146d79568abffcc408a
[05:33:21] info: Discovering: System.Runtime.Tests.dll (method display = ClassAndMethod, method display options = None)
[05:33:24] info: Discovered:  System.Runtime.Tests.dll (found 8930 of 9077 test cases)
[05:33:24] info: Using random seed for test cases: 575081098
[05:33:24] info: Using random seed for collections: 575081098
[05:33:24] info: Starting:    System.Runtime.Tests.dll

...
[EXECUTION TIMED OUT]
Exit Code:-3Executor timed out after 3600 seconds and was killed

this is not relevant to this change as none of this code uses the regex generator or runs the regex tests.

Copy link
Member

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@danmoseley danmoseley merged commit d225404 into dotnet:main Jan 5, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert to generated regex fixer is disabled on regex parse errors hit during counting captures
2 participants