Use shipping runtime.json for RID targeting #80074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsContributes to #32451
|
This was referenced Dec 31, 2022
Closed
- Use the shipping runtime.json file to target RIDs when building instead of the custom OSGroups.json which only contained a subset of the available rids. - To facilitate that, lower-case the existing platforms in the target frameworks strings which is the expected format anyway by the SDK and msbuild. This will eventually make it possible to bring some of the custom build infrastructure back into the SDK. - Remove a few outdated code pieces and update docs.
1 task
pavelsavara
approved these changes
Jan 2, 2023
This change shouldn't impact the produced assembly in any way. The metadata that is embedded into the assembly is just the target framework without the platform and the |
Merged
ViktorHofer
added a commit
that referenced
this pull request
Jan 11, 2023
Follow-up on #32451 Follow-up on #80074 In #43651, the "Windows" OS name was lowercased to achieve target frameworks with RIDs in them. At that time, the original plan was to lowercase all TargetOS values but that had to be cut because of resources. This PR finishes that and updates build systems, YML, markdowns and managed components. To not break existing developer workflows, the passed-in -os value is automatically lower-cased in the script entry points and validated in the msbuild entry point.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32451
Depends on dotnet/arcade#12041