Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that we don't root the compilation when using a custom exception marshalling type. #80147

Merged
merged 2 commits into from
Jan 5, 2023

Conversation

jkoritzinsky
Copy link
Member

This is similar to #79051 but for the new VirtualMethodIndex generator.

@ghost
Copy link

ghost commented Jan 3, 2023

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

This is similar to #79051 but for the new VirtualMethodIndex generator.

Author: jkoritzinsky
Assignees: -
Labels:

area-System.Runtime.InteropServices, source-generator

Milestone: -

@ghost ghost assigned jkoritzinsky Jan 3, 2023
Copy link
Member

@elinor-fung elinor-fung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't currently have ComInterfaceGenerator tests that check incremental generation, right?

@jkoritzinsky
Copy link
Member Author

Not yet. We should be able to refactor our incremental tests from LibraryImportGenerator to be reusable for different generators.

@jkoritzinsky
Copy link
Member Author

Failure is known, merging.

@jkoritzinsky jkoritzinsky merged commit 7952df7 into dotnet:main Jan 5, 2023
@jkoritzinsky jkoritzinsky deleted the vtable-stub-eh-no-comp-root branch January 5, 2023 22:30
@ghost ghost locked as resolved and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Runtime.InteropServices source-generator Indicates an issue with a source generator feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants