Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate android and wasm yaml templates to run the runtime tests after a "global-build" build step. #80157

Merged
merged 2 commits into from
Jan 4, 2023

Conversation

jkoritzinsky
Copy link
Member

I'm planning on utilizing this template in #74623 with CoreCLR and I noticed that we had two very similar copies. I figured it was a good idea to collapse them into a single copy and make it work for CoreCLR for at least simple cases.

@jkoritzinsky
Copy link
Member Author

/azp list

@ghost
Copy link

ghost commented Jan 4, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

I'm planning on utilizing this template in #74623 with CoreCLR and I noticed that we had two very similar copies. I figured it was a good idea to collapse them into a single copy and make it work for CoreCLR for at least simple cases.

Author: jkoritzinsky
Assignees: -
Labels:

area-Infrastructure-mono

Milestone: -

@azure-pipelines
Copy link

CI/CD Pipelines for this repository:

@jkoritzinsky
Copy link
Member Author

/azp run runtime-android, runtime-androidemulator

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s).

@jkoritzinsky
Copy link
Member Author

/azp run runtime-android, runtime-androidemulator

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@naricc
Copy link
Member

naricc commented Jan 4, 2023

I merged the wasm template into build-runtime-tests-and-send-to-helix.yml but I guess I didn't think to also merge in the android one. Thanks for cleaning that up.

@jkoritzinsky
Copy link
Member Author

/azp run runtime-android

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkoritzinsky
Copy link
Member Author

Failure is #79874. Merging this in to unblock my other work.

@jkoritzinsky jkoritzinsky merged commit 4960cab into dotnet:main Jan 4, 2023
@jkoritzinsky jkoritzinsky deleted the unify-runtimetests-template branch January 4, 2023 22:05
@ghost ghost locked as resolved and limited conversation to collaborators Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants