Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CustomAttributeData usage in IsByRefLike #80841

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

MichalStrehovsky
Copy link
Member

@MichalStrehovsky MichalStrehovsky commented Jan 19, 2023

Contributes to #80165.

Grabbing custom attribute data brings the entire reflection stack (we need properties, constructors, fields, methods).

We ask IsByRefLike in type loader constraint validation. Ideally we should be able to get rid of the type loader from a hello world, but that's for later. This is a more efficient implementation either way.

Cc @dotnet/ilc-contrib

Grabbing custom attribute data brings the entire reflection stack (we need properties, constructors, fields, methods).

We ask `IsByRefLike` in type loader constraint validation. Ideally we should be able to get rid of the type loader from a hello world, but that's for later. This is a more efficient implementation either way.
@ghost
Copy link

ghost commented Jan 19, 2023

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #80165.

Grabbing custom attribute data brings the entire reflection stack (we need properties, constructors, fields, methods).

We ask IsByRefLike in type loader constraint validation. Ideally we should be able to get rid of the type loader from a hello world, but that's for later. This is a more efficient implementation either way.

Cc https://github.com/orgs/dotnet/teams/ilc-contrib

Author: MichalStrehovsky
Assignees: MichalStrehovsky
Labels:

area-System.Reflection

Milestone: -

@ghost
Copy link

ghost commented Jan 19, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #80165.

Grabbing custom attribute data brings the entire reflection stack (we need properties, constructors, fields, methods).

We ask IsByRefLike in type loader constraint validation. Ideally we should be able to get rid of the type loader from a hello world, but that's for later. This is a more efficient implementation either way.

Cc @dotnet/ilc-contrib

Author: MichalStrehovsky
Assignees: MichalStrehovsky
Labels:

area-NativeAOT-coreclr

Milestone: -

@MichalStrehovsky MichalStrehovsky merged commit 6619e1b into dotnet:main Jan 19, 2023
@MichalStrehovsky MichalStrehovsky deleted the isbyreflik branch January 19, 2023 08:57
mdh1418 pushed a commit to mdh1418/runtime that referenced this pull request Jan 24, 2023
Grabbing custom attribute data brings the entire reflection stack (we need properties, constructors, fields, methods).

We ask `IsByRefLike` in type loader constraint validation. Ideally we should be able to get rid of the type loader from a hello world, but that's for later. This is a more efficient implementation either way.
@ghost ghost locked as resolved and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants