Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zlib: Remove unused exports #84603

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Zlib: Remove unused exports #84603

merged 1 commit into from
Apr 11, 2023

Conversation

GrabYourPitchforks
Copy link
Member

@GrabYourPitchforks GrabYourPitchforks commented Apr 11, 2023

This removes some of the zlib exports we're not using. In theory, this should help our future ability to tree-shake unneeded functions out of the native compression libraries, which can help reduce the attack surface of our native compression libraries.

Though the three PRs #84602, #84603, and #84604 are all related to zlib; they're each fully standalone and can be reviewed as isolated units.

@ghost
Copy link

ghost commented Apr 11, 2023

Tagging subscribers to this area: @dotnet/area-system-io-compression
See info in area-owners.md if you want to be subscribed.

Issue Details

This removes some of the zlib exports we're not using. In theory, this should help our future ability to tree-shake unneeded functions out of the native compression libraries, which can help reduce the attack surface of our native compression libraries.

Author: GrabYourPitchforks
Assignees: -
Labels:

area-System.IO.Compression

Milestone: -

Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks. LGTM.

@GrabYourPitchforks GrabYourPitchforks merged commit b26dae2 into main Apr 11, 2023
@ViktorHofer ViktorHofer deleted the levib/zlib_exports branch April 12, 2023 11:55
@ghost ghost locked as resolved and limited conversation to collaborators May 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants