Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose various Convert intrinsics for Avx512F, Avx512BW, and Avx512DQ #85281

Merged
merged 14 commits into from
Apr 25, 2023
Merged

Expose various Convert intrinsics for Avx512F, Avx512BW, and Avx512DQ #85281

merged 14 commits into from
Apr 25, 2023

Conversation

tannergooding
Copy link
Member

This exposes some instructions unique to the AVX512 family of instructions making progress towards completing:

@dotnet-issue-labeler dotnet-issue-labeler bot added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI new-api-needs-documentation labels Apr 24, 2023
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Apr 24, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

This exposes some instructions unique to the AVX512 family of instructions making progress towards completing:

Author: tannergooding
Assignees: -
Labels:

area-CodeGen-coreclr, new-api-needs-documentation
Milestone: -

@tannergooding tannergooding marked this pull request as ready for review April 24, 2023 23:35
@tannergooding
Copy link
Member Author

CC. @dotnet/jit-contrib, @dotnet/avx512-contrib

As with the last change, most of this is simply updating entries in the JIT intrinsic tables and exposing the managed side + xml docs.

@build-analysis build-analysis bot mentioned this pull request Apr 25, 2023
Open
2 tasks
@BruceForstall BruceForstall added the avx512 Related to the AVX-512 architecture label Apr 25, 2023
@build-analysis build-analysis bot mentioned this pull request Apr 25, 2023
Closed
@tannergooding
Copy link
Member Author

Fixed a few failures that were masked by #85056. Manually inspecting both logs shows everything passing again.

@tannergooding tannergooding mentioned this pull request Apr 25, 2023
Merged
@build-analysis build-analysis bot mentioned this pull request Apr 25, 2023
Closed
@tannergooding
Copy link
Member Author

tannergooding commented Apr 25, 2023 •
edited
Loading

Manually inspecting both logs shows everything passing again.

Also went and ran various other stress tests and those are all passing as well. This includes:

  • TieredCompilation=0
  • JitStressEvexEncoding=1
  • JitStress=1
  • JitStressRegs=0x2000

We'll want to run the official jobs after Fix XUnit Log Fixer Irregularities is merged in case any other stress legs have hidden failures

@tannergooding tannergooding mentioned this pull request Apr 25, 2023
Merged
@tannergooding
Copy link
Member Author

WASM timeouts are #85304

@tannergooding tannergooding merged commit f1a4cdd into dotnet:main Apr 25, 2023
@tannergooding tannergooding deleted the avx512-4 branch April 25, 2023 18:20
@ghost ghost locked as resolved and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EgorBo EgorBo EgorBo approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI avx512 Related to the AVX-512 architecture new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tannergooding @EgorBo @BruceForstall