Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose remaining Avx512 integer intrinsics which don't require VectorMask #86130

Merged
merged 4 commits into from
May 12, 2023

Conversation

tannergooding
Copy link
Member

This exposes the last few Avx512 intrinsics that don't require VectorMask and makes progress towards completing:

From the above, the only remaining APIs are the floating-point intrinsics that embed the rounding control. Covering these last few APIs is dependent on #84821, which adds the corresponding EVEX.b bit also used by embedded broadcasts.

I had thought I was going to need to cover Scatter/Gather as well, but the AVX-512 variants require use of the kmask registers to achieve functionality parity with the AVX variants and so are being pushed out alongside the VectorMask work.

@ghost ghost assigned tannergooding May 12, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI new-api-needs-documentation labels May 12, 2023
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented May 12, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

This exposes the last few Avx512 intrinsics that don't require VectorMask and makes progress towards completing:

From the above, the only remaining APIs are the floating-point intrinsics that embed the rounding control. Covering these last few APIs is dependent on #84821, which adds the corresponding EVEX.b bit also used by embedded broadcasts.

I had thought I was going to need to cover Scatter/Gather as well, but the AVX-512 variants require use of the kmask registers to achieve functionality parity with the AVX variants and so are being pushed out alongside the VectorMask work.

Author: tannergooding
Assignees: tannergooding
Labels:

area-CodeGen-coreclr, new-api-needs-documentation

Milestone: -

@BruceForstall BruceForstall added the avx512 Related to the AVX-512 architecture label May 12, 2023
@tannergooding tannergooding merged commit 081de35 into dotnet:main May 12, 2023
@tannergooding tannergooding deleted the avx512 branch May 12, 2023 15:17
@ghost ghost locked as resolved and limited conversation to collaborators Jun 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI avx512 Related to the AVX-512 architecture new-api-needs-documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants