Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Keyed Services Support to Dependency Injection #87183

Merged
merged 43 commits into from
Jul 13, 2023
Merged

Add Keyed Services Support to Dependency Injection #87183

merged 43 commits into from
Jul 13, 2023

Commits on Jul 5, 2023

  1. Keyed services

    @benjaminpetit
    benjaminpetit committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    02b1c4d View commit details
    Browse the repository at this point in the history

  2. Remove unecessary CompatibilitySuppressions.xml

    @benjaminpetit
    benjaminpetit committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    c26941c View commit details
    Browse the repository at this point in the history

  3. Remove some TODO

    @benjaminpetit
    benjaminpetit committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    e165c2e View commit details
    Browse the repository at this point in the history

  4. Minor test cleanup

    @benjaminpetit
    benjaminpetit committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    6fc500f View commit details
    Browse the repository at this point in the history

  5. Set error message for non keyed service provider

    @benjaminpetit
    benjaminpetit committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    bdc6bfb View commit details
    Browse the repository at this point in the history

  6. Move tests to Specification.Tests

    @benjaminpetit
    benjaminpetit committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    b0152ac View commit details
    Browse the repository at this point in the history

  7. Add open generic test

    @benjaminpetit
    benjaminpetit committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    57c62f7 View commit details
    Browse the repository at this point in the history

  8. dirty fix for ReplaceServiceAccessor

    @benjaminpetit
    benjaminpetit committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    e741b3e View commit details
    Browse the repository at this point in the history

  9. Add enumeration tests + fixes

    @benjaminpetit
    benjaminpetit committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    3c228f1 View commit details
    Browse the repository at this point in the history

  10. Add custom ToString() to KeyedService.AnyKey

    @benjaminpetit
    benjaminpetit committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    f84c8a1 View commit details
    Browse the repository at this point in the history

  11. Fix CallSiteValidator

    @benjaminpetit
    benjaminpetit committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    ddc7459 View commit details
    Browse the repository at this point in the history

  12. Merge ISupportRequiredKeyedService and ISupportKeyedService

    @benjaminpetit
    benjaminpetit committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    18f4879 View commit details
    Browse the repository at this point in the history

  13. Merge ISupportRequiredKeyedService and ISupportKeyedService

    @benjaminpetit
    benjaminpetit committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    3fa39b0 View commit details
    Browse the repository at this point in the history

  14. Fix ServiceCollectionDescriptorExtensions.TryAdd

    @benjaminpetit
    benjaminpetit committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    8b58809 View commit details
    Browse the repository at this point in the history

  15. Fix in ServiceCollectionDescriptorExtensions

    @benjaminpetit
    benjaminpetit committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    0d17ace View commit details
    Browse the repository at this point in the history

  16. Add IServiceProviderIsServiceKeyed

    @benjaminpetit
    benjaminpetit committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    68c3d71 View commit details
    Browse the repository at this point in the history

  17. Add IServiceProviderIsServiceKeyed

    @benjaminpetit
    benjaminpetit committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    38574c6 View commit details
    Browse the repository at this point in the history

  18. Some nit fixes

    @benjaminpetit
    benjaminpetit committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    24e1e72 View commit details
    Browse the repository at this point in the history

  19. Some nit fixes

    @benjaminpetit
    benjaminpetit committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    8111510 View commit details
    Browse the repository at this point in the history

  20. Cleanup CompatibilitySuppressions.xml

    @benjaminpetit
    benjaminpetit committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    b4eb5f2 View commit details
    Browse the repository at this point in the history

  21. WIP: ref fix tentative

    @benjaminpetit
    benjaminpetit committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    7cd4378 View commit details
    Browse the repository at this point in the history

  22. Fix ref/Microsoft.Extensions.DependencyInjection.Abstractions.cs

    @benjaminpetit
    benjaminpetit committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    c8e397c View commit details
    Browse the repository at this point in the history

  23. Fix ref/Microsoft.Extensions.DependencyInjection.cs

    @benjaminpetit
    benjaminpetit committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    840d3af View commit details
    Browse the repository at this point in the history

  24. Segregate keyed and non keyed ServiceDescriptor member, and throw whe… 

    …n misuse is detected
    @benjaminpetit
    benjaminpetit committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    8ccac9e View commit details
    Browse the repository at this point in the history

  25. Enforce that the type of the parameter marked with the ServiceKey att… 

    …ribute matches the type of the key used for lookup.
    @benjaminpetit
    benjaminpetit committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    2558c99 View commit details
    Browse the repository at this point in the history

  26. Add TryAddKeyed* extensions

    @benjaminpetit
    benjaminpetit committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    aea27cb View commit details
    Browse the repository at this point in the history

  27. Fixes and added tests

    @benjaminpetit
    benjaminpetit committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    afeaed1 View commit details
    Browse the repository at this point in the history

  28. Rename ISupportKeyedService to IKeyedServiceProvider and make it 

    implement IServiceProvider
    @benjaminpetit
    benjaminpetit committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    f2beeb2 View commit details
    Browse the repository at this point in the history

  29. Rename IServiceProviderIsServiceKeyed to IKeyedServiceProviderIsServi… 

    …ce and rename its method IsService to IsKeyedService
    @benjaminpetit
    benjaminpetit committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    115c3ef View commit details
    Browse the repository at this point in the history

  30. Merge extension methods from ServiceCollectionKeyedDescriptorExtensio… 

    …ns to ServiceCollectionDescriptorExtensions
    @benjaminpetit
    benjaminpetit committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    840d285 View commit details
    Browse the repository at this point in the history

  31. Merge extension methods from ServiceCollectionKeyedServiceExtensions … 

    …to ServiceCollectionServiceExtensions
    @benjaminpetit
    benjaminpetit committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    8f4e6f3 View commit details
    Browse the repository at this point in the history

  32. Restore wrongfully removed CompatibilitySuppressions.xml

    @benjaminpetit
    benjaminpetit committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    845d914 View commit details
    Browse the repository at this point in the history

  33. Files renaming

    @benjaminpetit
    benjaminpetit committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    a5705dc View commit details
    Browse the repository at this point in the history

  34. Make serviceKey nullable where possible

    @benjaminpetit
    benjaminpetit committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    460ecb4 View commit details
    Browse the repository at this point in the history

  35. IServiceProviderIsKeyedService

    @benjaminpetit
    benjaminpetit committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    72b2b5d View commit details
    Browse the repository at this point in the history

  36. Fix ServiceDescriptor.DebuggerToString()

    @benjaminpetit
    benjaminpetit committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    17b9312 View commit details
    Browse the repository at this point in the history

  37. Fix IEnumerableWithIsKeyedServiceAlwaysReturnsTrue

    @benjaminpetit
    benjaminpetit committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    ccbedc6 View commit details
    Browse the repository at this point in the history

  38. Fix ActivatorUtilities support of FromKeyedServicesAttribute

    @benjaminpetit
    benjaminpetit committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    db15ad7 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2023

  1. Minor fixes

    @benjaminpetit
    benjaminpetit committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    ec9b7ef View commit details
    Browse the repository at this point in the history

  2. Remove CompatibilitySuppressions.xml

    @benjaminpetit
    benjaminpetit committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    3a0a306 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Rollback CompatibilitySuppressions.xml

    @benjaminpetit
    benjaminpetit committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    44e2fea View commit details
    Browse the repository at this point in the history

  2. Add tests

    @benjaminpetit
    benjaminpetit committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    f7680e4 View commit details
    Browse the repository at this point in the history

  3. Make serviceKey nullable even when using a factory

    @benjaminpetit
    benjaminpetit committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    d9a0270 View commit details
    Browse the repository at this point in the history