Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add opt-in support for GeneratedComInterface/ComImport RCW interop #87583

Merged
merged 21 commits into from
Jul 18, 2023
Merged

Add opt-in support for GeneratedComInterface/ComImport RCW interop #87583

merged 21 commits into from
Jul 18, 2023

Commits on Jun 13, 2023

  1. Add initial implementation of GeneratedComInterface/ComImport RCW int… 

    …erop
    @jkoritzinsky
    jkoritzinsky committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    4c34ffb View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Actually define the .override entry for the dynamically emitted imple… 

    …mentation.
    @jkoritzinsky
    jkoritzinsky committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    34f4120 View commit details
    Browse the repository at this point in the history

  2. Interfaces don't have parents.

    @jkoritzinsky
    jkoritzinsky committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    5500bde View commit details
    Browse the repository at this point in the history

  3. Add basic test for the RCW interop scenario and fix various IL emit i… 

    …ssues.
    @jkoritzinsky
    jkoritzinsky committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    bb808ac View commit details
    Browse the repository at this point in the history

  4. Suppress a diagnostic that fixing would make the test useless.

    @jkoritzinsky
    jkoritzinsky committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    9d09747 View commit details
    Browse the repository at this point in the history

  5. Add a linker test and a feature flag to ensure that the ComImport int… 

    …erop support is trimmed away.
    @jkoritzinsky
    jkoritzinsky committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    971a2a5 View commit details
    Browse the repository at this point in the history

  6. Add negative test

    @jkoritzinsky
    jkoritzinsky committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    dcd4402 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. PR feedback and fix build.

    @jkoritzinsky
    jkoritzinsky committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    5406981 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2023

  1. Merge branch 'main' into com-adoption-configuration-rcw

    @jkoritzinsky
    jkoritzinsky committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    b058b40 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. Update the trimming test project template to allow unsafe blocks and … 

    …update the trimming test to use the generated code for a better example of real-world trimming scenarios.
    @jkoritzinsky
    jkoritzinsky committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    d0c0b3e View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. Merge branch 'main' into com-adoption-configuration-rcw

    @jkoritzinsky
    jkoritzinsky committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    9e915fc View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. Update src/libraries/System.Runtime.InteropServices/src/System/Runtim… 

    …e/InteropServices/Marshalling/ComImportInteropInterfaceDetailsStrategy.cs

Co-authored-by: Jan Kotas <jkotas@microsoft.com>
    @jkoritzinsky @jkotas
    jkoritzinsky and jkotas committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    670799a View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. PR feedback.

    @jkoritzinsky
    jkoritzinsky committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    af91b01 View commit details
    Browse the repository at this point in the history

  2. Remove suppression and fix fallback for COM interop flag.

    @jkoritzinsky
    jkoritzinsky committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    3124755 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2023

  1. Disable the warning with a pragma again for Vitek.

    @jkoritzinsky
    jkoritzinsky committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    cc068b3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into com-adoption-configuration-rcw

    @jkoritzinsky
    jkoritzinsky committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    e680980 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. Change back to an unconditional suppress to get the PR green again.

    @jkoritzinsky
    jkoritzinsky committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    7f36032 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. Implement feedback on form factor attributes.

    @jkoritzinsky
    jkoritzinsky committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    c42589d View commit details
    Browse the repository at this point in the history

  2. Refactor strategy selection to avoid non-windows failures.

    @jkoritzinsky
    jkoritzinsky committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    682ba71 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. Redo how we set suppressions to make sure they always are "needed".

    @jkoritzinsky
    jkoritzinsky committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    35f25a8 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. PR feedback and handle custom modifiers.

    @jkoritzinsky
    jkoritzinsky committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    3b5ae8b View commit details
    Browse the repository at this point in the history