Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress System.Drawing.Common dependency from System.Windows.Extensions #88157

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Suppress System.Drawing.Common dependency from System.Windows.Extensions #88157

merged 2 commits into from
Jul 5, 2023

Conversation

ericstj
Copy link
Member

@ericstj ericstj commented Jun 28, 2023

Dropping the package reference for System.Drawing.Common from System.Windows.Extensions.

This retains the type-forwards to avoid binary breaking changes but drops the package reference in the shipping product.

Related: dotnet/msbuild#8962

@ericstj ericstj added the breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. label Jun 28, 2023
@ericstj ericstj requested review from ViktorHofer and a team June 28, 2023 18:42
@ericstj ericstj mentioned this pull request Jun 28, 2023
Closed
@ghost ghost assigned ericstj Jun 28, 2023
@ghost ghost added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Jun 28, 2023
@ghost
Copy link

ghost commented Jun 28, 2023

Added needs-breaking-change-doc-created label because this PR has the breaking-change label.

When you commit this breaking change:

  1. Create and link to this PR and the issue a matching issue in the dotnet/docs repo using the breaking change documentation template, then remove this needs-breaking-change-doc-created label.
  2. Ask a committer to mail the .NET Breaking Change Notification DL.

Tagging @dotnet/compat for awareness of the breaking change.

@ghost
Copy link

ghost commented Jun 28, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Dropping the package reference for System.Drawing.Common from System.Windows.Extensions.

This retains the type-forwards to avoid binary breaking changes but drops the package reference in the shipping product.

Related: dotnet/msbuild#8962

Author: ericstj
Assignees: -
Labels:

area-Infrastructure-libraries, breaking-change
Milestone: -

@ghost
Copy link

ghost commented Jun 28, 2023

Tagging subscribers to this area: @dotnet/area-microsoft-win32
See info in area-owners.md if you want to be subscribed.

Issue Details

Dropping the package reference for System.Drawing.Common from System.Windows.Extensions.

This retains the type-forwards to avoid binary breaking changes but drops the package reference in the shipping product.

Related: dotnet/msbuild#8962

Author: ericstj
Assignees: ericstj
Labels:

area-Microsoft.Win32, breaking-change, needs-breaking-change-doc-created
Milestone: -

@ericstj ericstj added this to the 8.0.0 milestone Jun 28, 2023
@build-analysis build-analysis bot mentioned this pull request Jun 29, 2023
Closed
@ericstj
Copy link
Member Author

ericstj commented Jul 5, 2023

runtime-dev-innerloop failure is #88172

@ericstj ericstj merged commit 41f9766 into dotnet:main Jul 5, 2023
100 of 103 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Aug 4, 2023
@ericstj ericstj removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Oct 16, 2023
@ericstj ericstj deleted the winExtensionsPrivateDrawing branch October 16, 2023 19:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees

@ericstj ericstj

Labels
area-Microsoft.Win32 breaking-change Issue or PR that represents a breaking API or functional change over a prerelease.
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ericstj @ViktorHofer