Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print variable types when dumping the output #88420

Merged
merged 4 commits into from
Jul 7, 2023

Conversation

MichalPetryka
Copy link
Contributor

@MichalPetryka MichalPetryka commented Jul 5, 2023

This makes reasoning about local types easier.

Would help with checking the diffs for #88163, #88277 and #88006.

This makes reasoning about local types easier.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 5, 2023
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jul 5, 2023
@ghost
Copy link

ghost commented Jul 5, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

This makes reasoning about local types easier.

Author: MichalPetryka
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution

Milestone: -

@MichalPetryka MichalPetryka marked this pull request as ready for review July 5, 2023 17:48
@MichalPetryka
Copy link
Contributor Author

@MihuBot

@MichalPetryka
Copy link
Contributor Author

@MihuBot

@MichalPetryka
Copy link
Contributor Author

@MihuBot

@MichalPetryka
Copy link
Contributor Author

@EgorBo @jakobbotsch CoreLib jit-diff grew from 210MB to 218MB, some example diffs:

-;  V00 this         [V00,T00] (  3,  3   )     ref  ->  rdi         this class-hnd single-def
-;  V01 arg1         [V01,T01] (  3,  3   )     ref  ->  rsi         class-hnd single-def
+;  V00 this         [V00,T00] (  3,  3   )     ref  ->  rdi         this class-hnd single-def <System.Collections.Generic.NonRandomizedStringEqualityComparer+OrdinalComparer>
+;  V01 arg1         [V01,T01] (  3,  3   )     ref  ->  rsi         class-hnd single-def <System.Collections.Generic.IEqualityComparer`1[System.String]>
-;  V06 tmp1         [V06,T10] (  3,  0   )     ref  ->  rbx         class-hnd exact single-def "NewObj constructor temp"
-;* V07 tmp2         [V07    ] (  0,  0   )  struct (16) zero-ref    "ReadOnlySpan<T> for CreateSpan<T>"
+;  V06 tmp1         [V06,T10] (  3,  0   )     ref  ->  rbx         class-hnd exact single-def "NewObj constructor temp" <System.ArgumentException>
+;* V07 tmp2         [V07    ] (  0,  0   )  struct (16) zero-ref    "ReadOnlySpan<T> for CreateSpan<T>" <System.ReadOnlySpan`1[int]>
-;  V05 tmp1         [V05,T08] (  3,  6   )     ref  ->  r13         class-hnd exact single-def "NewObj constructor temp"
-;  V06 tmp2         [V06,T00] (  3, 24   )     ref  ->  [rbp-38H]   class-hnd spill-single-def "Inlining Arg"
-;  V07 tmp3         [V07,T02] (  2, 16   )     ref  ->  [rbp-40H]   class-hnd exact spill-single-def "Inlining Arg"
-;  V08 tmp4         [V08,T03] (  2, 16   )     ref  ->  rdx         class-hnd exact "Inlining Arg"
+;  V05 tmp1         [V05,T08] (  3,  6   )     ref  ->  r13         class-hnd exact single-def "NewObj constructor temp" <System.Collections.Generic.Dictionary`2[System.String,System.Object]>
+;  V06 tmp2         [V06,T00] (  3, 24   )     ref  ->  [rbp-38H]   class-hnd spill-single-def "Inlining Arg" <System.Collections.Generic.Dictionary`2[System.String,System.Object]>
+;  V07 tmp3         [V07,T02] (  2, 16   )     ref  ->  [rbp-40H]   class-hnd exact spill-single-def "Inlining Arg" <System.String>
+;  V08 tmp4         [V08,T03] (  2, 16   )     ref  ->  rdx         class-hnd exact "Inlining Arg" <System.String>
-;* V09 loc8         [V09    ] (  0,  0   )  simd32  ->  zero-ref   
+;* V09 loc8         [V09    ] (  0,  0   )  simd32  ->  zero-ref    <System.Runtime.Intrinsics.Vector256`1[ushort]>
 ;* V10 loc9         [V10    ] (  0,  0   )     int  ->  zero-ref   
-;* V11 loc10        [V11    ] (  0,  0   )  simd16  ->  zero-ref   
+;* V11 loc10        [V11    ] (  0,  0   )  simd16  ->  zero-ref    <System.Runtime.Intrinsics.Vector128`1[ushort]>
-;* V13 tmp7         [V13    ] (  0,  0   )  struct (16) zero-ref    multireg-arg "spilled call-like call argument"
-;* V14 tmp8         [V14    ] (  0,  0   )  struct (16) zero-ref    "Inline return value spill temp"
-;* V15 tmp9         [V15    ] (  0,  0   )  struct (16) zero-ref    ld-addr-op "NewObj constructor temp"
-;* V16 tmp10        [V16    ] (  0,  0   )  struct (16) zero-ref    ld-addr-op "Inline ldloca(s) first use temp"
+;* V13 tmp7         [V13    ] (  0,  0   )  struct (16) zero-ref    multireg-arg "spilled call-like call argument" <System.ReadOnlySpan`1[ushort]>
+;* V14 tmp8         [V14    ] (  0,  0   )  struct (16) zero-ref    "Inline return value spill temp" <System.ReadOnlySpan`1[ushort]>
+;* V15 tmp9         [V15    ] (  0,  0   )  struct (16) zero-ref    ld-addr-op "NewObj constructor temp" <System.ReadOnlySpan`1[ushort]>
+;* V16 tmp10        [V16    ] (  0,  0   )  struct (16) zero-ref    ld-addr-op "Inline ldloca(s) first use temp" <System.ReadOnlySpan`1[ushort]>
-;  V04 loc2         [V04,T12] (  3,  3   )     ref  ->  r14         class-hnd single-def
+;  V04 loc2         [V04,T12] (  3,  3   )     ref  ->  r14         class-hnd single-def <System.Collections.Generic.IEqualityComparer`1[System.__Canon]>
-;  V01 tmp1         [V01    ] (  1,  1   )     ref  ->  [rbp-08H]   do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"
-;  V02 tmp2         [V02    ] (  1,  1   )     ref  ->  [rbp-10H]   do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"
-;  V03 tmp3         [V03    ] (  1,  1   )     ref  ->  [rbp-18H]   do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"
-;  V04 tmp4         [V04    ] (  1,  1   )     ref  ->  [rbp-20H]   do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"
-;  V05 tmp5         [V05    ] (  1,  1   )     ref  ->  [rbp-28H]   do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"
-;  V06 tmp6         [V06    ] (  1,  1   )     ref  ->  [rbp-30H]   do-not-enreg[] must-init class-hnd exact "NewObj constructor temp"
+;  V01 tmp1         [V01    ] (  1,  1   )     ref  ->  [rbp-08H]   do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Func`1[System.String]>
+;  V02 tmp2         [V02    ] (  1,  1   )     ref  ->  [rbp-10H]   do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Lazy`1[System.String]>
+;  V03 tmp3         [V03    ] (  1,  1   )     ref  ->  [rbp-18H]   do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Func`1[System.String]>
+;  V04 tmp4         [V04    ] (  1,  1   )     ref  ->  [rbp-20H]   do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Lazy`1[System.String]>
+;  V05 tmp5         [V05    ] (  1,  1   )     ref  ->  [rbp-28H]   do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Collections.Generic.List`1[ushort]>
+;  V06 tmp6         [V06    ] (  1,  1   )     ref  ->  [rbp-30H]   do-not-enreg[] must-init class-hnd exact "NewObj constructor temp" <System.Collections.Generic.Dictionary`2[ushort,System.String]>
-;* V02 tmp1         [V02    ] (  0,  0   )  struct (16) zero-ref    do-not-enreg[SF] ld-addr-op "NewObj constructor temp"
-;  V03 tmp2         [V03,T00] ( 13, 26   )  struct (16) [rbp-20H]   do-not-enreg[SFA] multireg-arg "Inlining Arg"
-;  V04 tmp3         [V04,T02] (  3,  6   )     ref  ->  r15         class-hnd exact single-def "NewObj constructor temp"
+;* V02 tmp1         [V02    ] (  0,  0   )  struct (16) zero-ref    do-not-enreg[SF] ld-addr-op "NewObj constructor temp" <System.Guid>
+;  V03 tmp2         [V03,T00] ( 13, 26   )  struct (16) [rbp-20H]   do-not-enreg[SFA] multireg-arg "Inlining Arg" <System.Guid>
+;  V04 tmp3         [V04,T02] (  3,  6   )     ref  ->  r15         class-hnd exact single-def "NewObj constructor temp" <System.Diagnostics.Tracing.TraceLoggingEventHandleTable>

@EgorBo EgorBo merged commit 57608c3 into dotnet:main Jul 7, 2023
125 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants