Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono][jit] Enabled more intrinsics for V4 on arm64 #88912

Merged
merged 8 commits into from
Jul 24, 2023
Merged

[mono][jit] Enabled more intrinsics for V4 on arm64 #88912

merged 8 commits into from
Jul 24, 2023

Conversation

LeVladIonescu
Copy link
Contributor

This PR contributes to #86957.

  • Passing element_type to emit_xequal instead of computing it from arg1->klass
  • Get_Item, Set_item, Cctor will be addressed shortly after.

Enabled more intrinsics for V4
74a8b8a 
Signed-off-by: Vlad - Alexandru Ionescu <vlad-alexandruionescu@Vlads-MacBook-Pro-5.local>
@LeVladIonescu LeVladIonescu added this to the 8.0.0 milestone Jul 14, 2023
@LeVladIonescu LeVladIonescu self-assigned this Jul 14, 2023
@build-analysis build-analysis bot mentioned this pull request Jul 14, 2023
Open
Vlad - Alexandru Ionescu and others added 2 commits July 17, 2023 10:01
Passing etype->type instead of arg0_type
11867b9 
Signed-off-by: Vlad - Alexandru Ionescu <vlad-alexandruionescu@Vlads-MacBook-Pro-5.local>
@LeVladIonescu
Merge branch 'dotnet:main' into v4intrinsics
a27e23e
This was referenced Jul 17, 2023
Closed
Closed
LeVladIonescu and others added 3 commits July 20, 2023 18:59
@LeVladIonescu
Merge branch 'dotnet:main' into v4intrinsics
8e90eb1
Specify arg type to instruction
545b0eb 
Signed-off-by: Vlad - Alexandru Ionescu <vlad-alexandruionescu@Vlads-MacBook-Pro-5.local>
Merge branch 'v4intrinsics' of https://github.com/LeVladIonescu/runti…
e8930ed 
…me_fork into v4intrinsics
fanyang-mono
fanyang-mono approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@fanyang-mono fanyang-mono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@build-analysis build-analysis bot mentioned this pull request Jul 20, 2023
Closed
LeVladIonescu and others added 2 commits July 21, 2023 13:05
@LeVladIonescu
Merge branch 'dotnet:main' into v4intrinsics
239a5c4
Use already declared variable
a522264 
Signed-off-by: Vlad - Alexandru Ionescu <vlad-alexandruionescu@Vlads-MacBook-Pro-5.local>
@LeVladIonescu
Copy link
Contributor Author

Failures known

@LeVladIonescu LeVladIonescu merged commit 5b4bbda into dotnet:main Jul 24, 2023
96 of 100 checks passed
@LeVladIonescu LeVladIonescu deleted the v4intrinsics branch July 24, 2023 08:46
@ghost ghost locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fanyang-mono fanyang-mono fanyang-mono approved these changes

@jandupej jandupej Awaiting requested review from jandupej

@vargaz vargaz Awaiting requested review from vargaz

@lambdageek lambdageek Awaiting requested review from lambdageek

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

Assignees

@LeVladIonescu LeVladIonescu

Labels
area-Codegen-JIT-mono
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@LeVladIonescu @fanyang-mono