Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CA1863 (Use 'CompositeFormat') as suggestion #89029

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

stephentoub
Copy link
Member

I ran it over runtime, and the only things flagged were for exceptional cases where it's not worth using. Rather than a bunch of suppressions, I'm just enabling it as info-level.

I ran it over runtime, and the only things flagged were for exceptional cases where it's not worth using.  Rather than a bunch of suppressions, I'm just enabling it as info-level.
@stephentoub stephentoub requested a review from buyaa-n July 17, 2023 16:50
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 17, 2023
@ghost ghost assigned stephentoub Jul 17, 2023
@buyaa-n buyaa-n added area-Meta and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 17, 2023
@ghost
Copy link

ghost commented Jul 17, 2023

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

I ran it over runtime, and the only things flagged were for exceptional cases where it's not worth using. Rather than a bunch of suppressions, I'm just enabling it as info-level.

Author: stephentoub
Assignees: stephentoub
Labels:

area-Meta

Milestone: -

@stephentoub stephentoub merged commit 023b54a into dotnet:main Jul 17, 2023
167 of 170 checks passed
@stephentoub stephentoub deleted the ca1863 branch July 17, 2023 20:53
@ghost ghost locked as resolved and limited conversation to collaborators Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants