Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT][mono][aot] Implementation of nollvm init method #89074
[DRAFT][mono][aot] Implementation of nollvm init method #89074
Changes from all commits
a6b88f9
c6fc40a
95a8470
03e1389
9140661
aad02cc
9976eaf
49dcf2e
1dbcc28
2bad646
0e4b036
00a9b41
f5eee3e
bfe9c5e
73537b5
cc43423
406e5bd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed offline, would be good to think of memory leaks. Is it allocated within the mempool?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vargaz do we want to propagate this error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if this is a correct way to invoke wrappers generated in:
runtime/src/mono/mono/mini/aot-compiler.c
Line 4470 in 6229f5f
During the native linking, there is an undefined symbols for architecture arm64:
I think it comes from method prolog trying to invoke the init wrapper, but I would expect invocation of
wrapper_other_object_init_method_intptr_intptr
instead of_mono_aot_HelloWorld_init_method
. @vargaz What we are doing wrong?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, I am not 100% how this should work but I think the body of
_mono_aot_HelloWorld_init_method
is never generated, looking at the compiler output: https://gist.github.com/ivanpovazan/96542ae24088a4a5e735d414b92e4c9ethere are only jumps to that symbol
bl _mono_aot_HelloWorld_init_method
, but it is not generated anywhere.