Enable use-after-return checking in ASAN #89204
Open
+146
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run runtime-sanitized |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-sanitized |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jul 20, 2023
|
/azp run runtime-sanitized |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkoritzinsky
added a commit
to jkoritzinsky/dotnet-buildtools-prereqs-docker
that referenced
this pull request
Jul 27, 2023
We're trying to start using the official ASAN headers in dotnet/runtime#89204 and we're hitting issues about where to include them from. This PR updates them to be placed next to clang like they are in a standard clang installation and not in the rootfs like we were doing
|
/azp run runtime-sanitized |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-sanitized |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-sanitized |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Aug 9, 2023
|
/azp run runtime-sanitized |
…pointer adjustment, not before.
|
/azp run runtime-sanitized |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-sanitized |
|
Azure Pipelines successfully started running 1 pipeline(s). |
… where we need to figure out a good solution.
…umented helper methods.
|
/azp run runtime-sanitized |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-sanitized |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Feb 14, 2024
This was referenced Feb 16, 2024
am11
reviewed
Mar 9, 2024
| @@ -141,6 +141,20 @@ elseif (CLR_CMAKE_HOST_UNIX) | |||
| endif(MSVC) | |||
|
|
|||
| if (CLR_CMAKE_ENABLE_SANITIZERS) | |||
| enable_language(C) | |||
There was a problem hiding this comment.
Is it necessary? IOW, are there cases where C not enabled and control reaches this line?
# Conflicts: # eng/native/configurecompiler.cmake # src/coreclr/pal/src/include/pal/palinternal.h
This was referenced Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89133