Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono][interp] Add implicit conversion of floating-point call args #89428

Merged
merged 3 commits into from
Jul 28, 2023

Conversation

kotlarmilos
Copy link
Member

@kotlarmilos kotlarmilos commented Jul 25, 2023

This PR adds implicit conversion of floating-point call args and enables the conversion for inlined methods.

Fixes #89385

@ghost
Copy link

ghost commented Jul 25, 2023

Tagging subscribers to this area: @BrzVlad, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR adds explicit conversion of floating-point call args and enables the conversion for inlined methods.

Fixes #89385

Author: kotlarmilos
Assignees: kotlarmilos
Labels:

area-Codegen-Interpreter-mono

Milestone: 8.0.0

@lewing
Copy link
Member

lewing commented Jul 25, 2023

the debugger failure is known

@BrzVlad BrzVlad changed the title [mono][interp] Add explicit conversion of floating-point call args [mono][interp] Add implicit conversion of floating-point call args Jul 26, 2023
@kotlarmilos

This comment was marked as outdated.

@kotlarmilos
Copy link
Member Author

/azp run runtime-ioslike

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 89428 in repo dotnet/runtime

@kotlarmilos
Copy link
Member Author

/azp run runtime-ioslike

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmilos
Copy link
Member Author

/azp run runtime-ioslike

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmilos
Copy link
Member Author

The failures are known and shouldn't be related.

@kotlarmilos kotlarmilos merged commit f5ca995 into dotnet:main Jul 28, 2023
95 of 107 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Aug 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mono] The bitcast test fails with exit code 104 on apple mobile platforms
3 participants