Improve zlib defenses on mono #89898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Mono defines HOST_WIN32, not CLR_CMAKE_HOST_WIN32 - Follow same pattern from src\native\eventpipe\CMakeLists.txt
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-system-io-compression Issue DetailsImprovement to #84604. See also #89532 (comment). Mono doesn't define the same CMAKE variables as coreclr, so mono was picking up the Unix-style defenses, even when producing a Windows compilation unit. This change allows both mono and coreclr to pick up the same protections. This pattern is based on the existing file: runtime/src/native/eventpipe/CMakeLists.txt Lines 98 to 101 in d099f07
|
|
Tagging @dotnet/runtime-infrastructure - Can folks with cmake knowledge please take a look at this? |
jkoritzinsky
approved these changes
Aug 3, 2023
hoyosjs
approved these changes
Aug 3, 2023
akoeplinger
approved these changes
Aug 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement to #84604. See also #89532 (comment).
Mono doesn't define the same CMAKE variables as coreclr, so mono was picking up the Unix-style defenses, even when producing a Windows compilation unit. This change allows both mono and coreclr to pick up the same protections.
This pattern is based on the existing file:
runtime/src/native/eventpipe/CMakeLists.txt
Lines 98 to 101 in d099f07